Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add phpseclib to storage suggestions #570

Merged
merged 2 commits into from
Jul 11, 2017
Merged

Add phpseclib to storage suggestions #570

merged 2 commits into from
Jul 11, 2017

Conversation

jdpedrie
Copy link
Contributor

No description provided.

@jdpedrie jdpedrie added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 10, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2017
@dwsupplee
Copy link
Contributor

If we rely on a specific version of phpseclib, could that please be noted in the suggest?

@jdpedrie
Copy link
Contributor Author

@dwsupplee done!

@dwsupplee dwsupplee merged commit 1552db6 into googleapis:master Jul 11, 2017
@dwsupplee dwsupplee mentioned this pull request Jul 11, 2017
Merged
@jdpedrie jdpedrie deleted the storage-suggestion branch November 16, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpedrie @dwsupplee @googlebot