Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async trace reporter readme #566

Merged
merged 3 commits into from
Jul 10, 2017
Merged

Async trace reporter readme #566

merged 3 commits into from
Jul 10, 2017

Conversation

chingor13
Copy link
Contributor

Re-adding the example to the Trace README.md about using the AsyncReporter

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2017
@dwsupplee
Copy link
Contributor

This looks great! A quick note, though - should we also notate that the AsyncReporter isn't 100% reliant on the batch daemon and that users can rely on register_shutdown_function or flush to process queued traces?

@chingor13
Copy link
Contributor Author

I'm actually wondering if I should add a factory method on the TraceClient like we do for the pubsub batch publisher. The constructor for the AsyncReporter vs SyncReporter take different options and we can actually use AsyncReporter in place of SyncReporter (if IS_BATCH_DAEMON_RUNNING is false)

@dwsupplee
Copy link
Contributor

That sounds like it would be a solid addition 👍.

@dwsupplee dwsupplee merged commit 5cd241e into googleapis:master Jul 10, 2017
@dwsupplee dwsupplee mentioned this pull request Jul 11, 2017
@dwsupplee dwsupplee added the api: cloudtrace Issues related to the Cloud Trace API. label Jul 11, 2017
@chingor13 chingor13 deleted the async-trace-reporter-readme branch July 12, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudtrace Issues related to the Cloud Trace API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants