Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add name attr in phpunit config testsuite #5597

Merged
merged 1 commit into from
Nov 9, 2022
Merged

chore: add name attr in phpunit config testsuite #5597

merged 1 commit into from
Nov 9, 2022

Conversation

vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Nov 8, 2022 •
edited
Loading

Fixes: #5382

Checkout latest test logs have this unnecessary warning:

Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 4:
  - Element 'testsuite': The attribute 'name' is required but missing.

  Test results may not be as expected.

@vishwarajanand vishwarajanand marked this pull request as ready for review November 8, 2022 09:08
@vishwarajanand vishwarajanand requested review from a team as code owners November 8, 2022 09:08
@vishwarajanand vishwarajanand added the api: accessapproval Issues related to the Access Approval API. label Nov 8, 2022
@bshaffer bshaffer merged commit b95a20b into main Nov 9, 2022
@bshaffer bshaffer deleted the vishwarajanand-patch-5382 branch November 9, 2022 16:35
@bshaffer
Copy link
Contributor

bshaffer commented Nov 9, 2022

Good catch!

vishwarajanand added a commit to vishwarajanand/google-cloud-php that referenced this pull request Nov 12, 2022
@vishwarajanand
chore: add name in phpunit config (googleapis#5597)
f505342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
api: accessapproval Issues related to the Access Approval API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix attribute names in phpunit configurations
2 participants
@vishwarajanand @bshaffer