Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [RecommendationEngine] Fix recommendationengine resource name configuration #5494

Merged
merged 2 commits into from
Sep 13, 2022
Merged

fix: [RecommendationEngine] Fix recommendationengine resource name configuration #5494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d45392c
fix: Fix recommendationengine resource name configuration
gcf-owl-bot[bot] Sep 12, 2022
405a604
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions RecommendationEngine/metadata/V1Beta1/RecommendationengineResources.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions RecommendationEngine/src/V1beta1/Gapic/CatalogServiceGapicClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ private static function getCatalogNameTemplate()
private static function getCatalogItemPathNameTemplate()
{
if (self::$catalogItemPathNameTemplate == null) {
self::$catalogItemPathNameTemplate = new PathTemplate('projects/{project}/locations/{location}/catalogs/{catalog}/catalogItems/{catalog_item_path=**}');
self::$catalogItemPathNameTemplate = new PathTemplate('projects/{project}/locations/{location}/catalogs/{catalog}/catalogItems/{catalog_item_path}');
}

return self::$catalogItemPathNameTemplate;
Expand Down Expand Up @@ -214,7 +214,7 @@ public static function catalogItemPathName($project, $location, $catalog, $catal
* The following name formats are supported:
* Template: Pattern
* - catalog: projects/{project}/locations/{location}/catalogs/{catalog}
* - catalogItemPath: projects/{project}/locations/{location}/catalogs/{catalog}/catalogItems/{catalog_item_path=**}
* - catalogItemPath: projects/{project}/locations/{location}/catalogs/{catalog}/catalogItems/{catalog_item_path}
*
* The optional $template argument can be supplied to specify a particular pattern,
* and must match one of the templates listed above. If no $template argument is
Expand Down