Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Firestore] add readonly compatibility #5410

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jul 28, 2022

Splitting Firestore from the "Many APIs" PR (#5408) so we can review/merge separately.

@bshaffer bshaffer marked this pull request as ready for review July 28, 2022 19:19
@bshaffer bshaffer requested review from a team as code owners July 28, 2022 19:19
@bshaffer bshaffer changed the title feat: Update Firestore with latest changes from owlbot feat: [Firestore] update gapic-generator-php to v1.5.0 Jul 28, 2022
Copy link
Contributor Author

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is LGTM but I can't approve my own PR

@bshaffer bshaffer changed the title feat: [Firestore] update gapic-generator-php to v1.5.0 feat: [Firestore] add readonly compatibility Jul 28, 2022
@dwsupplee dwsupplee merged commit 9e93f2a into main Jul 28, 2022
@dwsupplee dwsupplee deleted the owl-bot-copy-Firestore-manual branch July 28, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants