chore: remove core dev dependency, snippet.xml, and system.xml #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed
google/cloud-corefromrequire-devfor all libraries which don't use it. These libraries also containedphpunit-snippet.xml.distandphpunit-system.xml.distfiles, which were not running any tests. I removed these as well, because those config files were relying ongoogle/cloud-corefor their bootstrap.There are still 20 GAPIC libraries which use
google/cloud-corefor System tests (see #5267). We will need to migrate these away from usinggoogle/cloud-coreby adding the required classes togoogle/gaxOR by removing the use of these classes.