feat: support IN/NOT_IN/NOT_EQUAL operators #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwarajanand
added
the
do not merge
vishwarajanand
changed the title
vishwarajanand
force-pushed
the
datastore_operators
branch
from
2720804 to
ef5d933
Compare
vishwarajanand
force-pushed
the
datastore_operators
branch
from
ef5d933 to
80e284d
Compare
…oogleapis#5115) * fix!: removing misspelled field, add correctly spelled field PiperOrigin-RevId: 428023165 Source-Link: googleapis/googleapis@63d374d Source-Link: googleapis/googleapis-gen@6be9b6c Copy-Tag: eyJwIjoiUHViU3ViLy5Pd2xCb3QueWFtbCIsImgiOiI2YmU5YjZjNmI2Yzg1ZmFjZTE4YWRiZGJkZDNmYzA2MzU2ODEwYjRhIn0= * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…tps://google.aip.dev/123#annotating-resource-types (googleapis#5199) * fix!: Updated resource patterns to comply with https://google.aip.dev/123#annotating-resource-types PiperOrigin-RevId: 438230444 Source-Link: googleapis/googleapis@1821985 Source-Link: googleapis/googleapis-gen@30cb53f Copy-Tag: eyJwIjoiQ2VydGlmaWNhdGVNYW5hZ2VyLy5Pd2xCb3QueWFtbCIsImgiOiIzMGNiNTNmOTlkMjUyYjM2NmFhODM3YjM4Y2Y5ZDFmOGIyODNlYzRhIn0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…cking store used (googleapis#5162) * feat: Added DatabaseType field for the type of backing store used feat: Added AVRO DatabaseDumpSpec for importing and exporting Avro files feat: Added additional endTime field for MetadataImports feat: Added RESTORING status on Backups feat: Added support to record the services that are restoring the backup feat: Added configuration for Dataplex integration feat: Added support for IAM management for metadata resources feat: Added AuxiliaryVersionConfig for configuring the auxiliary hive versions during creation or update of the DPMS instance feat: Added NetworkConfig for exposing the DPMS endpoint in multiple subnetworks using PSC (this skips the need for VPC peering) feat: Added EncryptionConfig which contains information used to configure the Dataproc Metastore service to encrypt customer data at rest (CMEK) docs: formatting improvements PiperOrigin-RevId: 436271267 Source-Link: googleapis/googleapis@463caca Source-Link: googleapis/googleapis-gen@e1cd573 Copy-Tag: eyJwIjoiRGF0YXByb2NNZXRhc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6ImUxY2Q1NzMyMWM2YmM2ZWU1OTljMWNiM2I4MzE3OTQ1OTgwNDhhNmYifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…to support fuzzy matching (googleapis#5159) * docs: Added functionality in the companyDisplayNames filter to support fuzzy matching PiperOrigin-RevId: 435467010 Source-Link: googleapis/googleapis@cb38285 Source-Link: googleapis/googleapis-gen@799e10e Copy-Tag: eyJwIjoiVGFsZW50Ly5Pd2xCb3QueWFtbCIsImgiOiI3OTllMTBlODJkMDRhYTI3YWFmYmM2YzUzN2Y1YmUxZWFmODkxY2FkIn0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat: add WarmAndPing request for channel priming PiperOrigin-RevId: 428795660 Source-Link: googleapis/googleapis@6cce671 Source-Link: googleapis/googleapis-gen@2282bc1 Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjIyODJiYzFiMDgxMzY0ZWE3ODMzMDBiZTkxYThjMTRjYjRhNzE4YzQifQ== * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Add ListHotTablets API method and protobufs PiperOrigin-RevId: 436758628 Source-Link: googleapis/googleapis@92ab86a Source-Link: googleapis/googleapis-gen@931ef11 Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjkzMWVmMTE0ZDVmODQ1YWJmMTE3YmY4ZTBhMjk4MzZjYTMwMGI2OTQifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Update `cpu_utilization_percent` limit docs: Remove the limitation of all clusters in a CMEK instance must use the same key PiperOrigin-RevId: 438385300 Source-Link: googleapis/googleapis@c59f02e Source-Link: googleapis/googleapis-gen@04d03d1 Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjA0ZDAzZDE3YWFmYTdiNDQyMmY3M2M5MzYwMGYwNDA1NDI4MTdmY2QifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…a3 protos. (googleapis#5137) * fix!: Use http binding with location field as primary http bindings Changing HTTP bindings and/or their order might be a breaking change for libraries. PiperOrigin-RevId: 430239565 Source-Link: googleapis/googleapis@71fe7ff Source-Link: googleapis/googleapis-gen@1f496cc Copy-Tag: eyJwIjoiRGF0YWZsb3cvLk93bEJvdC55YW1sIiwiaCI6IjFmNDk2Y2MzNmRkNzc5MjFlNDVhMjc4MTE0YmJjMjE5OGNjODM1MmEifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Add the ability to plumb environment capabilities through v1beta3 protos. PiperOrigin-RevId: 434899727 Source-Link: googleapis/googleapis@392ae91 Source-Link: googleapis/googleapis-gen@febf173 Copy-Tag: eyJwIjoiRGF0YWZsb3cvLk93bEJvdC55YW1sIiwiaCI6ImZlYmYxNzMxNzI0ODNmY2ViZDU2NjhkZDMyZjNkNzM1MmE0NDIwY2UifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
|
|
bshaffer
reviewed
Apr 22, 2022
There was a problem hiding this comment.
This is LGTM from me but we should wait for @dwsupplee to review!
dwsupplee
suggested changes
May 16, 2022
|
Friendly reminder about the request to add the new short operator to the documentation for the filter method (I'd comment on the line, but since there is no diff there github won't let me). |
dwsupplee
approved these changes
May 26, 2022
vishwarajanand
removed
the
do not merge
vishwarajanand
added a commit
that referenced
this pull request
Jul 2, 2022
* Added new operators and unit tests * fix: [PubSub] removing misspelled field, add correctly spelled field (#5115) * fix!: removing misspelled field, add correctly spelled field PiperOrigin-RevId: 428023165 Source-Link: googleapis/googleapis@63d374d Source-Link: googleapis/googleapis-gen@6be9b6c Copy-Tag: eyJwIjoiUHViU3ViLy5Pd2xCb3QueWFtbCIsImgiOiI2YmU5YjZjNmI2Yzg1ZmFjZTE4YWRiZGJkZDNmYzA2MzU2ODEwYjRhIn0= * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * fix: [CertificateManager] Updated resource patterns to comply with https://google.aip.dev/123#annotating-resource-types (#5199) * fix!: Updated resource patterns to comply with https://google.aip.dev/123#annotating-resource-types PiperOrigin-RevId: 438230444 Source-Link: googleapis/googleapis@1821985 Source-Link: googleapis/googleapis-gen@30cb53f Copy-Tag: eyJwIjoiQ2VydGlmaWNhdGVNYW5hZ2VyLy5Pd2xCb3QueWFtbCIsImgiOiIzMGNiNTNmOTlkMjUyYjM2NmFhODM3YjM4Y2Y5ZDFmOGIyODNlYzRhIn0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: [DataprocMetastore] Added DatabaseType field for the type of backing store used (#5162) * feat: Added DatabaseType field for the type of backing store used feat: Added AVRO DatabaseDumpSpec for importing and exporting Avro files feat: Added additional endTime field for MetadataImports feat: Added RESTORING status on Backups feat: Added support to record the services that are restoring the backup feat: Added configuration for Dataplex integration feat: Added support for IAM management for metadata resources feat: Added AuxiliaryVersionConfig for configuring the auxiliary hive versions during creation or update of the DPMS instance feat: Added NetworkConfig for exposing the DPMS endpoint in multiple subnetworks using PSC (this skips the need for VPC peering) feat: Added EncryptionConfig which contains information used to configure the Dataproc Metastore service to encrypt customer data at rest (CMEK) docs: formatting improvements PiperOrigin-RevId: 436271267 Source-Link: googleapis/googleapis@463caca Source-Link: googleapis/googleapis-gen@e1cd573 Copy-Tag: eyJwIjoiRGF0YXByb2NNZXRhc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6ImUxY2Q1NzMyMWM2YmM2ZWU1OTljMWNiM2I4MzE3OTQ1OTgwNDhhNmYifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * docs: [Talent] Added functionality in the companyDisplayNames filter to support fuzzy matching (#5159) * docs: Added functionality in the companyDisplayNames filter to support fuzzy matching PiperOrigin-RevId: 435467010 Source-Link: googleapis/googleapis@cb38285 Source-Link: googleapis/googleapis-gen@799e10e Copy-Tag: eyJwIjoiVGFsZW50Ly5Pd2xCb3QueWFtbCIsImgiOiI3OTllMTBlODJkMDRhYTI3YWFmYmM2YzUzN2Y1YmUxZWFmODkxY2FkIn0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: introduce hot tablet/ping and warm RPCs (#5119) * feat: add WarmAndPing request for channel priming PiperOrigin-RevId: 428795660 Source-Link: googleapis/googleapis@6cce671 Source-Link: googleapis/googleapis-gen@2282bc1 Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjIyODJiYzFiMDgxMzY0ZWE3ODMzMDBiZTkxYThjMTRjYjRhNzE4YzQifQ== * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Add ListHotTablets API method and protobufs PiperOrigin-RevId: 436758628 Source-Link: googleapis/googleapis@92ab86a Source-Link: googleapis/googleapis-gen@931ef11 Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjkzMWVmMTE0ZDVmODQ1YWJmMTE3YmY4ZTBhMjk4MzZjYTMwMGI2OTQifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Update `cpu_utilization_percent` limit docs: Remove the limitation of all clusters in a CMEK instance must use the same key PiperOrigin-RevId: 438385300 Source-Link: googleapis/googleapis@c59f02e Source-Link: googleapis/googleapis-gen@04d03d1 Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjA0ZDAzZDE3YWFmYTdiNDQyMmY3M2M5MzYwMGYwNDA1NDI4MTdmY2QifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: Add the ability to plumb environment capabilities through v1beta3 protos. (#5137) * fix!: Use http binding with location field as primary http bindings Changing HTTP bindings and/or their order might be a breaking change for libraries. PiperOrigin-RevId: 430239565 Source-Link: googleapis/googleapis@71fe7ff Source-Link: googleapis/googleapis-gen@1f496cc Copy-Tag: eyJwIjoiRGF0YWZsb3cvLk93bEJvdC55YW1sIiwiaCI6IjFmNDk2Y2MzNmRkNzc5MjFlNDVhMjc4MTE0YmJjMjE5OGNjODM1MmEifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Add the ability to plumb environment capabilities through v1beta3 protos. PiperOrigin-RevId: 434899727 Source-Link: googleapis/googleapis@392ae91 Source-Link: googleapis/googleapis-gen@febf173 Copy-Tag: eyJwIjoiRGF0YWZsb3cvLk93bEJvdC55YW1sIiwiaCI6ImZlYmYxNzMxNzI0ODNmY2ViZDU2NjhkZDMyZjNkNzM1MmE0NDIwY2UifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * limiting shorthand operators to not equals * Added short operator to filter documentation Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation to support IN/NOT_IN/NOT_EQUAL operators for datastore PHP SDK
Changes:
IN,NOT_INandNOT_EQUALTests
UTs before adding tests:
UTs after adding tests:
Reviewer Help Needed: