fix(managedidentities): [ManagedIdentities] add ancillary service bindings to service_yaml #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
PiperOrigin-RevId: 422903615 Source-Link: googleapis/googleapis@12c0a1f Source-Link: googleapis/googleapis-gen@d6e18f3 Copy-Tag: eyJwIjoiTWFuYWdlZElkZW50aXRpZXMvLk93bEJvdC55YW1sIiwiaCI6ImQ2ZTE4ZjM2MjU3MjAwNTQ2NTE3N2Y0YTNkNTVlMGUyZjIwZDM5MDIifQ==
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
the
api: managedidentities
kokoro-team
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
kokoro-team
removed
the
kokoro:force-run
bshaffer
approved these changes
Jan 20, 2022
| @@ -304,19 +435,13 @@ public function __construct(array $options = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function attachTrust(array $optionalArgs = []) | |||
| public function attachTrust($name, $trust, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -392,23 +517,14 @@ public function attachTrust(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function createMicrosoftAdDomain(array $optionalArgs = []) | |||
| public function createMicrosoftAdDomain($parent, $domainName, $domain, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -469,15 +585,12 @@ public function createMicrosoftAdDomain(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function deleteDomain(array $optionalArgs = []) | |||
| public function deleteDomain($name, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -542,19 +655,13 @@ public function deleteDomain(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function detachTrust(array $optionalArgs = []) | |||
| public function detachTrust($name, $trust, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -592,15 +699,12 @@ public function detachTrust(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function getDomain(array $optionalArgs = []) | |||
| public function getDomain($name, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -667,15 +771,12 @@ public function getDomain(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function listDomains(array $optionalArgs = []) | |||
| public function listDomains($parent, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -760,23 +861,14 @@ public function listDomains(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function reconfigureTrust(array $optionalArgs = []) | |||
| public function reconfigureTrust($name, $targetDomainName, $targetDnsIpAddresses, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -814,15 +906,12 @@ public function reconfigureTrust(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function resetAdminPassword(array $optionalArgs = []) | |||
| public function resetAdminPassword($name, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -892,18 +982,13 @@ public function resetAdminPassword(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function updateDomain(array $optionalArgs = []) | |||
| public function updateDomain($updateMask, $domain, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
| @@ -969,19 +1054,13 @@ public function updateDomain(array $optionalArgs = []) | |||
| * | |||
| * @experimental | |||
| */ | |||
| public function validateTrust(array $optionalArgs = []) | |||
| public function validateTrust($name, $trust, array $optionalArgs = []) | |||
There was a problem hiding this comment.
This breaks BC, but in a beta client, so it's okay
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 422903615
Source-Link: googleapis/googleapis@12c0a1f
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d6e18f362572005465177f4a3d55e0e2f20d3902
Copy-Tag: eyJwIjoiTWFuYWdlZElkZW50aXRpZXMvLk93bEJvdC55YW1sIiwiaCI6ImQ2ZTE4ZjM2MjU3MjAwNTQ2NTE3N2Y0YTNkNTVlMGUyZjIwZDM5MDIifQ==