Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Spanner] exclude partial veneer SpannerClient from owlbot #4994

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix: [Spanner] exclude partial veneer SpannerClient from owlbot #4994

merged 1 commit into from
Jan 10, 2022

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jan 8, 2022 •
edited
Loading

See #4888

Without this, tests are failing in spanner with the following error (because the getTransport method is being overwritten)

Prophecy\Exception\Doubler\MethodNotFoundException: Method `Double\Google\Cloud\Spanner\V1\SpannerClient\P73::getTransport()` not found.

@bshaffer bshaffer requested review from a team as code owners January 8, 2022 19:52
@bshaffer bshaffer requested a review from tmatsuo January 8, 2022 19:52
@bshaffer bshaffer changed the title fix: exclude partial veneer SpannerClient from owlbot fix: [Spanner] exclude partial veneer SpannerClient from owlbot Jan 8, 2022
@bshaffer bshaffer merged commit 0f59589 into master Jan 10, 2022
@bshaffer bshaffer deleted the fix-exclude-spanner-client branch January 10, 2022 20:39
@release-please release-please bot mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @tmatsuo