chore(AnalyticsData): Delete old style files. #4985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should also copy files like these: src/V1beta/resources/beta_analytics_data_descriptor_config.php src/V1beta/resources/beta_analytics_data_rest_client_config.php So I also changed the copy_excludes pattern.
product-auto-label
bot
added
the
api: analyticsdata
bshaffer
reviewed
Jan 7, 2022
| @@ -34,10 +36,19 @@ | |||
| src=src, | |||
| dest=dest, | |||
| copy_excludes=[ | |||
| src / "**/*_*.php" | |||
| src / "**/[A-Z]*_*.php" | |||
There was a problem hiding this comment.
Hmm, is beta_analytics_data_rest_client_config.php included in these lists? If so, we definitely need to update all of these 😞
Would it be better to submit a PR to update all of these?
There was a problem hiding this comment.
Added here
Would it also be better to be specific by directory instead of using the double asterisk? I think in this case we would want src / "*/[A-Z]*_*.php"
| try: | ||
| os.remove(f) | ||
| except: | ||
| print(f"Failed to remove '{f}'") |
There was a problem hiding this comment.
I am not sure we want this logic in owlbot.py since this is something that only needs to be performed once. I think I'd prefer to manually remove these. WDYT?
|
Closing in favor of #4993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should also copy files like these:
src/V1beta/resources/beta_analytics_data_descriptor_config.php
src/V1beta/resources/beta_analytics_data_rest_client_config.php
So I also changed the copy_excludes pattern.