feat: [Logging] update client libraries to support Database operations #4921
Conversation
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
PiperOrigin-RevId: 419710013 Source-Link: googleapis/googleapis@b7c9d05 Source-Link: googleapis/googleapis-gen@ae49827 Copy-Tag: eyJwIjoiTG9nZ2luZy8uT3dsQm90LnlhbWwiLCJoIjoiYWU0OTgyNzljNGU3MWNkNGFhNmUwNjU1ZTkyYTY5M2RmOTc0NzJjNCJ9
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
kokoro-team
removed
the
kokoro:force-run
bshaffer
changed the title
There was a problem hiding this comment.
We have removal of static methods and the moving of changes from optional to required.
The latter implies a BC-breaking change in the protobuf layer, and there's nothing we can do about that as far as I know, as that implies a breaking change on the API side.
We could consider fixing this in the Client Library in order to preserve BC, as the API will already be throwing API Exceptions here anyway, and there's no reason to additionally break the user's code.
| */ | ||
| public static function billingSinkName($billingAccount, $sink) |
There was a problem hiding this comment.
Removing this method breaks BC
| */ | ||
| public static function sinkName($project, $sink) |
There was a problem hiding this comment.
Removing this method breaks BC
| * | ||
| * @throws ApiException if the remote call fails | ||
| */ | ||
| public function getCmekSettings($name, array $optionalArgs = []) |
There was a problem hiding this comment.
This new method signature breaks BC. $name moved from an optional argument to a required argument. The previous method signature looked like this:
public function getCmekSettings(array $optionalArgs = [])This shouldn't be allowed by the API, so we need to look into how this happened.
| */ | ||
| public function updateExclusion($name, $exclusion, $updateMask, array $optionalArgs = []) | ||
| public function updateCmekSettings($name, $cmekSettings, array $optionalArgs = []) |
There was a problem hiding this comment.
This method had both optional parameters $name and $cmekSettings moved to be required arguments.
|
superceded by #5046 |
PiperOrigin-RevId: 419710013
Source-Link: googleapis/googleapis@b7c9d05
Source-Link: https://github.com/googleapis/googleapis-gen/commit/ae498279c4e71cd4aa6e0655e92a693df97472c4
Copy-Tag: eyJwIjoiTG9nZ2luZy8uT3dsQm90LnlhbWwiLCJoIjoiYWU0OTgyNzljNGU3MWNkNGFhNmUwNjU1ZTkyYTY5M2RmOTc0NzJjNCJ9