Modify exceptions when a whitelist may be present #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpedrie
added
api: core
do not merge
googlebot
added
the
cla: yes
src/Core/WhitelistTrait.php
Outdated
| @@ -0,0 +1,49 @@ | |||
| <?php | |||
| /** | |||
| * Copyright 2016 Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jdpedrie
changed the title
jdpedrie
removed
the
do not merge
|
@michaelbausor @dwsupplee PTAL. All the currently whitelisted methods are tested, save deleteSnapshot, which I can't really test accurately seeing as I can't create a resource to delete. :) The environment variable |
src/Core/WhitelistTrait.php
Outdated
| $e->setMessage('NOTE: Error may be due to Whitelist Restriction. ' . $e->getMessage()); | ||
|
|
||
| throw $e; | ||
| } catch (\Exception $e) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Core/WhitelistTrait.php
Outdated
| return call_user_func_array($callable, $args); | ||
| } catch (NotFoundException $e) { | ||
| $e->setMessage('NOTE: Error may be due to Whitelist Restriction. ' . $e->getMessage()); | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/PubSub/Connection/Grpc.php
Outdated
| return $this->send([$this->subscriberClient, 'listSnapshots'], [ | ||
| $this->pluck('project', $args), | ||
| $args | ||
| return $this->whitelist([$this, 'send'], [ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
reviewed
May 19, 2017
src/Core/WhitelistTrait.php
Outdated
| * @param array $callable The request callable. | ||
| * @param array $args Request arguments. | ||
| * @return array | ||
| * @throws WhitelistException |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dwsupplee @michaelbausor refactored some things. PTAL |
dwsupplee
approved these changes
May 22, 2017
michaelbausor
approved these changes
May 22, 2017
Merged
dwsupplee
pushed a commit
that referenced
this pull request
Jun 22, 2017
* Add ext-grpc as a dep for services that only provides grpc lib (#475) * Choose rest over grpc for now. (#477) * project to projectId (#484) * RFC: Adds removePolicy to Iam Policy Builder (#480) * Adds removePolicy to Iam Policy Builder * adds snippet test * Introduce support for Cloud Spanner (#333) * introduce cache based session pool and streaming execute/read * Implement remaining API, add system tests. * Buffer result sets and retry only with error code unavailable * Fix parameterization and value mapping Add system test coverage. Add more read system tests and fix KeyRange issues Spanner transaction system tests Add remaining p0 spanner system tests * allow user determined row formatting doc fix address code review move symfony/lock from require to suggest * Update README and Spanner composer.json * update verbiage * small tweaks * Add resource-prefix header to outgoing spanner requests * Add Video Intelligence GAPIC client (#492) * Add GAPIC only video intelligence * Add docs * Update namespace capitalization * Address PR comments * Fix * escaping * Update grpc install description * inverse retry condition * Prepare v0.29.0 (#493) * Update docs to include new core types (#494) * README updates / Add VI to list of includes (#495) * readme fixes * Add VI to list of includes * increase ServiceBuilder version for v0.29.0 release (#496) * Prepare v0.30.0 (#497) * Prepare v0.30.0 * Add GAPIC to Spanner docs table of contents * make param type more specific (#500) * fixes extraStatements bug for Spanner\Instance::createDatabase (#499) * fixes extraStatements bug for Spanner\Instance::createDatabase * fixes tests * corrects spanner dependency on core and removes symfony/lock requirement (#503) * corrects spanner dependency on core and removes symfony/lock requirement * changes core php req to >=5.5 * Cast keySet keys to arrays instead of wrapping them (#505) * cast keySet keys to arrays instead of wrapping them * adds tests for keyset formatting * Prepare v0.30.1 (#501) * Prepare v0.30.1 * Bump cloud-core version * Bump proto-client-php version * Update GAPICs for Spanner (#508) * Update spanner gapic * Update video intelligence * Update Spanner, VideoIntelligence and Speech * Address PR feedback * Modify exceptions when a whitelist may be present (#482) * Modify exceptions when a whitelist may be present * Add Whitelist system tests * Code review fixes * Refactor out additional call_user_func * Prepare v0.31.0 (#510) * Prepare v0.31.1 (#511) * Request Tracing (#456) * Request tracing (#4) * Implement the Trace REST API Client. Implements basic Trace and TraceSpan resources. TraceClient tests Fix tests. Connection needed to be protected Code style fixes * Rename some methods, move a required parameter * remove labels class for now * Refactor TraceSpan to store attributes directly in the info array * Fix Trace namespace in ServiceBuilder * Rename some getter methods. Whitelist attributes in TraceSpan constructor * Fix aliases for Core classes * Request tracing prototype * Create more namespaces * RequestTracer should return results * Add labels to the primary span detected from the response. * Snippet tests and phpcs fixes * Fix cs * add Trace test * Add system tests for using the TraceClient * list traces test depends on creating the traces * Copyrights and documentation comments * remove debug statement * Fix some typehinting and documentation * Refactor Trace to lazy load span data if not set. * Convert listTraces output from a generator to an ItemIterator * Add @see note for Trace list function * Fix Trace system tests * Add TraceSpan factory function on Trace * Add test for lazy fetching span data from the api * Fix RequestTracer to work with updated apis * Make RequestTracer an instance. Static functions are redirected to the singleton instance of RequestTracer * Add options to trace insert and trace get calls * Remove REST Connection emulator hooks - there is no Trace emulator. * Trace#info no longer checks to see if you have already specified spans * Documentation updates * Remove projectId getter/setter from Trace. * cs ignore for long documentation links * Docs, fixing traces resultLimit, set timezone * Generate a span name from a cleaned backtrace * If the trace span is not created within a class, is the file's basename * Some backtrace entries do not have line numbers * Revert the change to info() that tried to maintain an info array * Add SamplerFactory * Add 3 more example trace reporters * Add GAE labels to the root span * fix missing semicolon * Fix GAE env variable parsing * Inject the cacheItemClass name into the QpsSampler. CacheItemPoolInterface implementations often are linked to their CacheItemInterface implementations in order to communicate expiry (not part of the PSR-6 spec. * Add a NullReporter. * TracerInterface now returns only spans rather than creating a trace record. Add tests * Add TraceContext class. * TraceSpan start and end times can accept numerics (timestamps) or strings * Documentation updates * close all spans at the end of the request * Adding version, license, docs for creating new google/cloud-trace package * Use factories for generating sampler and reporter from the initial RequestTracer::start() * Rename TraceReporter -> SyncReporter * Detect PSR-6 apc/apcu cache. Detect default start time from headers. * can't use pluck staticly * Docs and examples for RequestTracer * Remove ReporterFactory. Add documentation * Adding tests * SamplerFactory tests * Add suggested packages for the cache adapters * Add ExtensionTracer which will not work until the stackdriver extension is available * JsonSerializable TraceSpan * Fix serializable * Return trace context headers if provided to the request * Prefix service name in front of version if present * Extension tracer can handle initial trace context * Put the version header back to just the version * Add Trace section to main README * fix default spanId * finish -> end * Rename finish -> end for consistency across languages * Rename instrument -> inSpan to match other languages * Fix the label name for the module version for GAE * Update README for google/cloud-trace * TracerInterface no longer returns the span started or stopped. The extension tracer cannot return a reference to its internal representation of a TraceSpan. It would cause strange behavior to be able to modify the span object returned by reference. * ensure -> finally * Remove many unused label constants. Add load balancer labels. Add trace client version to agent * Test fixes * Separate the RequestTracer static methods from the RequestHandler instance. * Fix CS * Move default logger level to constructor * Cannot typehint floats * Add snippet tests * Implement the AsyncReporter that uses the BatchRunner * Add another search path for the autoloader for the batch daemon * Only need to use 2 worker threads by default * Removing AsyncReporter for now, until Batch package is back * clarify adding root label from adding label to current span * Add the addRootLabel to extension tracer * Adding tests for tracers and reporters * Fix EchoReporter test * Doc fixes * Documentation update for suggesting cache implementations * Documentation updates. is_a -> instanceof * Fix the snippet test syntax for updated dev tools * Spacing and doc updates for PR comments. * Documentation types, pin google/cloud-core version. SamplerFactory only handles arrays. * Documentation fixes * Handle failure cases for LoggerReporter and FileReporter * Add ramsey/uuid dependency for generating trace ids (uuids) * Remove extension tracer for now * Fix use statement for SamplerInterface * Update required symfony/lock dependency version (#515) * Test component composer integration, bump gax requirement (#507) * Test component composer integeration, bump gax requirement * Use dry-run and repository path * Switch to exec() * Add to travis build * Skip if grpc missing * Prepare v0.32.0 (#516) * Prepare v0.32.0 * Bump monitoring, error reporting * Fix TraceClient example on the main README.md (#517) * Correct the suggested commit for symfony/lock (#518) * Add Query system tests, fix value mapping bugs (#520) * Update Translate service definition, add system tests, remove documentation for non-existent option (#522) * Prepare v0.32.1 (#523) * Add support for bucket labels (#529) * Added new option "uploadProgressCallback" to method $bucket->upload(). (#412) * Added new option "uploadProgressCallback" to method $bucket->upload(). It's a callable parameter which defines a callback function/method to be triggered on each successfully uploaded chunk if resumable upload is used. * Include forgotten namespace. * Added description of the new constructor method in class ResumableUploader. * Added missing namespace dependency. * Alphabetical order in used namespaces. Fixed option name in constructor's description. Syntax changes to follow the project's consistency. Used cached getSize() value instead of additional calculations on each upload iteration. * Added test method for showing how to use the 'uploadProgressCallback' option for tracking the upload progress. * Fix some Travis build requirements to pass the build successfully. * Fixed some Travis build requirements to pass the build successfully. * Rollback .gitignore changes * Move type constants to Database (#532) * Skip creating the labels info until there are labels. (#542) Revert extension name change in test * upgrade to google/auth ^1.0 (#535) * upgrade to google/auth ^1.0 * Update google/gax dependency * Fixing a documentation comment in SpannerClient class construct (#543) * Add support for Storage - Requester Pays (#527) * Add support for Storage - Requester Pays * Add system tests for requester pays * Address code review * Fix StorageObject::exists() * Fix system test for storage IAM * Add whitelist notice
dwsupplee
pushed a commit
to dwsupplee/gcloud-php
that referenced
this pull request
Jun 30, 2017
* Add ext-grpc as a dep for services that only provides grpc lib (googleapis#475) * Choose rest over grpc for now. (googleapis#477) * project to projectId (googleapis#484) * RFC: Adds removePolicy to Iam Policy Builder (googleapis#480) * Adds removePolicy to Iam Policy Builder * adds snippet test * Introduce support for Cloud Spanner (googleapis#333) * introduce cache based session pool and streaming execute/read * Implement remaining API, add system tests. * Buffer result sets and retry only with error code unavailable * Fix parameterization and value mapping Add system test coverage. Add more read system tests and fix KeyRange issues Spanner transaction system tests Add remaining p0 spanner system tests * allow user determined row formatting doc fix address code review move symfony/lock from require to suggest * Update README and Spanner composer.json * update verbiage * small tweaks * Add resource-prefix header to outgoing spanner requests * Add Video Intelligence GAPIC client (googleapis#492) * Add GAPIC only video intelligence * Add docs * Update namespace capitalization * Address PR comments * Fix * escaping * Update grpc install description * inverse retry condition * Prepare v0.29.0 (googleapis#493) * Update docs to include new core types (googleapis#494) * README updates / Add VI to list of includes (googleapis#495) * readme fixes * Add VI to list of includes * increase ServiceBuilder version for v0.29.0 release (googleapis#496) * Prepare v0.30.0 (googleapis#497) * Prepare v0.30.0 * Add GAPIC to Spanner docs table of contents * make param type more specific (googleapis#500) * fixes extraStatements bug for Spanner\Instance::createDatabase (googleapis#499) * fixes extraStatements bug for Spanner\Instance::createDatabase * fixes tests * corrects spanner dependency on core and removes symfony/lock requirement (googleapis#503) * corrects spanner dependency on core and removes symfony/lock requirement * changes core php req to >=5.5 * Cast keySet keys to arrays instead of wrapping them (googleapis#505) * cast keySet keys to arrays instead of wrapping them * adds tests for keyset formatting * Prepare v0.30.1 (googleapis#501) * Prepare v0.30.1 * Bump cloud-core version * Bump proto-client-php version * Update GAPICs for Spanner (googleapis#508) * Update spanner gapic * Update video intelligence * Update Spanner, VideoIntelligence and Speech * Address PR feedback * Modify exceptions when a whitelist may be present (googleapis#482) * Modify exceptions when a whitelist may be present * Add Whitelist system tests * Code review fixes * Refactor out additional call_user_func * Prepare v0.31.0 (googleapis#510) * Prepare v0.31.1 (googleapis#511) * Request Tracing (googleapis#456) * Request tracing (googleapis#4) * Implement the Trace REST API Client. Implements basic Trace and TraceSpan resources. TraceClient tests Fix tests. Connection needed to be protected Code style fixes * Rename some methods, move a required parameter * remove labels class for now * Refactor TraceSpan to store attributes directly in the info array * Fix Trace namespace in ServiceBuilder * Rename some getter methods. Whitelist attributes in TraceSpan constructor * Fix aliases for Core classes * Request tracing prototype * Create more namespaces * RequestTracer should return results * Add labels to the primary span detected from the response. * Snippet tests and phpcs fixes * Fix cs * add Trace test * Add system tests for using the TraceClient * list traces test depends on creating the traces * Copyrights and documentation comments * remove debug statement * Fix some typehinting and documentation * Refactor Trace to lazy load span data if not set. * Convert listTraces output from a generator to an ItemIterator * Add @see note for Trace list function * Fix Trace system tests * Add TraceSpan factory function on Trace * Add test for lazy fetching span data from the api * Fix RequestTracer to work with updated apis * Make RequestTracer an instance. Static functions are redirected to the singleton instance of RequestTracer * Add options to trace insert and trace get calls * Remove REST Connection emulator hooks - there is no Trace emulator. * Trace#info no longer checks to see if you have already specified spans * Documentation updates * Remove projectId getter/setter from Trace. * cs ignore for long documentation links * Docs, fixing traces resultLimit, set timezone * Generate a span name from a cleaned backtrace * If the trace span is not created within a class, is the file's basename * Some backtrace entries do not have line numbers * Revert the change to info() that tried to maintain an info array * Add SamplerFactory * Add 3 more example trace reporters * Add GAE labels to the root span * fix missing semicolon * Fix GAE env variable parsing * Inject the cacheItemClass name into the QpsSampler. CacheItemPoolInterface implementations often are linked to their CacheItemInterface implementations in order to communicate expiry (not part of the PSR-6 spec. * Add a NullReporter. * TracerInterface now returns only spans rather than creating a trace record. Add tests * Add TraceContext class. * TraceSpan start and end times can accept numerics (timestamps) or strings * Documentation updates * close all spans at the end of the request * Adding version, license, docs for creating new google/cloud-trace package * Use factories for generating sampler and reporter from the initial RequestTracer::start() * Rename TraceReporter -> SyncReporter * Detect PSR-6 apc/apcu cache. Detect default start time from headers. * can't use pluck staticly * Docs and examples for RequestTracer * Remove ReporterFactory. Add documentation * Adding tests * SamplerFactory tests * Add suggested packages for the cache adapters * Add ExtensionTracer which will not work until the stackdriver extension is available * JsonSerializable TraceSpan * Fix serializable * Return trace context headers if provided to the request * Prefix service name in front of version if present * Extension tracer can handle initial trace context * Put the version header back to just the version * Add Trace section to main README * fix default spanId * finish -> end * Rename finish -> end for consistency across languages * Rename instrument -> inSpan to match other languages * Fix the label name for the module version for GAE * Update README for google/cloud-trace * TracerInterface no longer returns the span started or stopped. The extension tracer cannot return a reference to its internal representation of a TraceSpan. It would cause strange behavior to be able to modify the span object returned by reference. * ensure -> finally * Remove many unused label constants. Add load balancer labels. Add trace client version to agent * Test fixes * Separate the RequestTracer static methods from the RequestHandler instance. * Fix CS * Move default logger level to constructor * Cannot typehint floats * Add snippet tests * Implement the AsyncReporter that uses the BatchRunner * Add another search path for the autoloader for the batch daemon * Only need to use 2 worker threads by default * Removing AsyncReporter for now, until Batch package is back * clarify adding root label from adding label to current span * Add the addRootLabel to extension tracer * Adding tests for tracers and reporters * Fix EchoReporter test * Doc fixes * Documentation update for suggesting cache implementations * Documentation updates. is_a -> instanceof * Fix the snippet test syntax for updated dev tools * Spacing and doc updates for PR comments. * Documentation types, pin google/cloud-core version. SamplerFactory only handles arrays. * Documentation fixes * Handle failure cases for LoggerReporter and FileReporter * Add ramsey/uuid dependency for generating trace ids (uuids) * Remove extension tracer for now * Fix use statement for SamplerInterface * Update required symfony/lock dependency version (googleapis#515) * Test component composer integration, bump gax requirement (googleapis#507) * Test component composer integeration, bump gax requirement * Use dry-run and repository path * Switch to exec() * Add to travis build * Skip if grpc missing * Prepare v0.32.0 (googleapis#516) * Prepare v0.32.0 * Bump monitoring, error reporting * Fix TraceClient example on the main README.md (googleapis#517) * Correct the suggested commit for symfony/lock (googleapis#518) * Add Query system tests, fix value mapping bugs (googleapis#520) * Update Translate service definition, add system tests, remove documentation for non-existent option (googleapis#522) * Prepare v0.32.1 (googleapis#523) * Add support for bucket labels (googleapis#529) * Added new option "uploadProgressCallback" to method $bucket->upload(). (googleapis#412) * Added new option "uploadProgressCallback" to method $bucket->upload(). It's a callable parameter which defines a callback function/method to be triggered on each successfully uploaded chunk if resumable upload is used. * Include forgotten namespace. * Added description of the new constructor method in class ResumableUploader. * Added missing namespace dependency. * Alphabetical order in used namespaces. Fixed option name in constructor's description. Syntax changes to follow the project's consistency. Used cached getSize() value instead of additional calculations on each upload iteration. * Added test method for showing how to use the 'uploadProgressCallback' option for tracking the upload progress. * Fix some Travis build requirements to pass the build successfully. * Fixed some Travis build requirements to pass the build successfully. * Rollback .gitignore changes * Move type constants to Database (googleapis#532) * Skip creating the labels info until there are labels. (googleapis#542) Revert extension name change in test * upgrade to google/auth ^1.0 (googleapis#535) * upgrade to google/auth ^1.0 * Update google/gax dependency * Fixing a documentation comment in SpannerClient class construct (googleapis#543) * Add support for Storage - Requester Pays (googleapis#527) * Add support for Storage - Requester Pays * Add system tests for requester pays * Address code review * Fix StorageObject::exists() * Fix system test for storage IAM * Add whitelist notice
dwsupplee
pushed a commit
to dwsupplee/gcloud-php
that referenced
this pull request
Jun 30, 2017
* Add ext-grpc as a dep for services that only provides grpc lib (googleapis#475) * Choose rest over grpc for now. (googleapis#477) * project to projectId (googleapis#484) * RFC: Adds removePolicy to Iam Policy Builder (googleapis#480) * Adds removePolicy to Iam Policy Builder * adds snippet test * Introduce support for Cloud Spanner (googleapis#333) * introduce cache based session pool and streaming execute/read * Implement remaining API, add system tests. * Buffer result sets and retry only with error code unavailable * Fix parameterization and value mapping Add system test coverage. Add more read system tests and fix KeyRange issues Spanner transaction system tests Add remaining p0 spanner system tests * allow user determined row formatting doc fix address code review move symfony/lock from require to suggest * Update README and Spanner composer.json * update verbiage * small tweaks * Add resource-prefix header to outgoing spanner requests * Add Video Intelligence GAPIC client (googleapis#492) * Add GAPIC only video intelligence * Add docs * Update namespace capitalization * Address PR comments * Fix * escaping * Update grpc install description * inverse retry condition * Prepare v0.29.0 (googleapis#493) * Update docs to include new core types (googleapis#494) * README updates / Add VI to list of includes (googleapis#495) * readme fixes * Add VI to list of includes * increase ServiceBuilder version for v0.29.0 release (googleapis#496) * Prepare v0.30.0 (googleapis#497) * Prepare v0.30.0 * Add GAPIC to Spanner docs table of contents * make param type more specific (googleapis#500) * fixes extraStatements bug for Spanner\Instance::createDatabase (googleapis#499) * fixes extraStatements bug for Spanner\Instance::createDatabase * fixes tests * corrects spanner dependency on core and removes symfony/lock requirement (googleapis#503) * corrects spanner dependency on core and removes symfony/lock requirement * changes core php req to >=5.5 * Cast keySet keys to arrays instead of wrapping them (googleapis#505) * cast keySet keys to arrays instead of wrapping them * adds tests for keyset formatting * Prepare v0.30.1 (googleapis#501) * Prepare v0.30.1 * Bump cloud-core version * Bump proto-client-php version * Update GAPICs for Spanner (googleapis#508) * Update spanner gapic * Update video intelligence * Update Spanner, VideoIntelligence and Speech * Address PR feedback * Modify exceptions when a whitelist may be present (googleapis#482) * Modify exceptions when a whitelist may be present * Add Whitelist system tests * Code review fixes * Refactor out additional call_user_func * Prepare v0.31.0 (googleapis#510) * Prepare v0.31.1 (googleapis#511) * Request Tracing (googleapis#456) * Request tracing (googleapis#4) * Implement the Trace REST API Client. Implements basic Trace and TraceSpan resources. TraceClient tests Fix tests. Connection needed to be protected Code style fixes * Rename some methods, move a required parameter * remove labels class for now * Refactor TraceSpan to store attributes directly in the info array * Fix Trace namespace in ServiceBuilder * Rename some getter methods. Whitelist attributes in TraceSpan constructor * Fix aliases for Core classes * Request tracing prototype * Create more namespaces * RequestTracer should return results * Add labels to the primary span detected from the response. * Snippet tests and phpcs fixes * Fix cs * add Trace test * Add system tests for using the TraceClient * list traces test depends on creating the traces * Copyrights and documentation comments * remove debug statement * Fix some typehinting and documentation * Refactor Trace to lazy load span data if not set. * Convert listTraces output from a generator to an ItemIterator * Add @see note for Trace list function * Fix Trace system tests * Add TraceSpan factory function on Trace * Add test for lazy fetching span data from the api * Fix RequestTracer to work with updated apis * Make RequestTracer an instance. Static functions are redirected to the singleton instance of RequestTracer * Add options to trace insert and trace get calls * Remove REST Connection emulator hooks - there is no Trace emulator. * Trace#info no longer checks to see if you have already specified spans * Documentation updates * Remove projectId getter/setter from Trace. * cs ignore for long documentation links * Docs, fixing traces resultLimit, set timezone * Generate a span name from a cleaned backtrace * If the trace span is not created within a class, is the file's basename * Some backtrace entries do not have line numbers * Revert the change to info() that tried to maintain an info array * Add SamplerFactory * Add 3 more example trace reporters * Add GAE labels to the root span * fix missing semicolon * Fix GAE env variable parsing * Inject the cacheItemClass name into the QpsSampler. CacheItemPoolInterface implementations often are linked to their CacheItemInterface implementations in order to communicate expiry (not part of the PSR-6 spec. * Add a NullReporter. * TracerInterface now returns only spans rather than creating a trace record. Add tests * Add TraceContext class. * TraceSpan start and end times can accept numerics (timestamps) or strings * Documentation updates * close all spans at the end of the request * Adding version, license, docs for creating new google/cloud-trace package * Use factories for generating sampler and reporter from the initial RequestTracer::start() * Rename TraceReporter -> SyncReporter * Detect PSR-6 apc/apcu cache. Detect default start time from headers. * can't use pluck staticly * Docs and examples for RequestTracer * Remove ReporterFactory. Add documentation * Adding tests * SamplerFactory tests * Add suggested packages for the cache adapters * Add ExtensionTracer which will not work until the stackdriver extension is available * JsonSerializable TraceSpan * Fix serializable * Return trace context headers if provided to the request * Prefix service name in front of version if present * Extension tracer can handle initial trace context * Put the version header back to just the version * Add Trace section to main README * fix default spanId * finish -> end * Rename finish -> end for consistency across languages * Rename instrument -> inSpan to match other languages * Fix the label name for the module version for GAE * Update README for google/cloud-trace * TracerInterface no longer returns the span started or stopped. The extension tracer cannot return a reference to its internal representation of a TraceSpan. It would cause strange behavior to be able to modify the span object returned by reference. * ensure -> finally * Remove many unused label constants. Add load balancer labels. Add trace client version to agent * Test fixes * Separate the RequestTracer static methods from the RequestHandler instance. * Fix CS * Move default logger level to constructor * Cannot typehint floats * Add snippet tests * Implement the AsyncReporter that uses the BatchRunner * Add another search path for the autoloader for the batch daemon * Only need to use 2 worker threads by default * Removing AsyncReporter for now, until Batch package is back * clarify adding root label from adding label to current span * Add the addRootLabel to extension tracer * Adding tests for tracers and reporters * Fix EchoReporter test * Doc fixes * Documentation update for suggesting cache implementations * Documentation updates. is_a -> instanceof * Fix the snippet test syntax for updated dev tools * Spacing and doc updates for PR comments. * Documentation types, pin google/cloud-core version. SamplerFactory only handles arrays. * Documentation fixes * Handle failure cases for LoggerReporter and FileReporter * Add ramsey/uuid dependency for generating trace ids (uuids) * Remove extension tracer for now * Fix use statement for SamplerInterface * Update required symfony/lock dependency version (googleapis#515) * Test component composer integration, bump gax requirement (googleapis#507) * Test component composer integeration, bump gax requirement * Use dry-run and repository path * Switch to exec() * Add to travis build * Skip if grpc missing * Prepare v0.32.0 (googleapis#516) * Prepare v0.32.0 * Bump monitoring, error reporting * Fix TraceClient example on the main README.md (googleapis#517) * Correct the suggested commit for symfony/lock (googleapis#518) * Add Query system tests, fix value mapping bugs (googleapis#520) * Update Translate service definition, add system tests, remove documentation for non-existent option (googleapis#522) * Prepare v0.32.1 (googleapis#523) * Add support for bucket labels (googleapis#529) * Added new option "uploadProgressCallback" to method $bucket->upload(). (googleapis#412) * Added new option "uploadProgressCallback" to method $bucket->upload(). It's a callable parameter which defines a callback function/method to be triggered on each successfully uploaded chunk if resumable upload is used. * Include forgotten namespace. * Added description of the new constructor method in class ResumableUploader. * Added missing namespace dependency. * Alphabetical order in used namespaces. Fixed option name in constructor's description. Syntax changes to follow the project's consistency. Used cached getSize() value instead of additional calculations on each upload iteration. * Added test method for showing how to use the 'uploadProgressCallback' option for tracking the upload progress. * Fix some Travis build requirements to pass the build successfully. * Fixed some Travis build requirements to pass the build successfully. * Rollback .gitignore changes * Move type constants to Database (googleapis#532) * Skip creating the labels info until there are labels. (googleapis#542) Revert extension name change in test * upgrade to google/auth ^1.0 (googleapis#535) * upgrade to google/auth ^1.0 * Update google/gax dependency * Fixing a documentation comment in SpannerClient class construct (googleapis#543) * Add support for Storage - Requester Pays (googleapis#527) * Add support for Storage - Requester Pays * Add system tests for requester pays * Address code review * Fix StorageObject::exists() * Fix system test for storage IAM * Add whitelist notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
NotFoundExceptionis thrown by a method which may be under whitelist restriction, the exception is intercepted and the error message is modified to indicate the possible problem to the user.Still to come is integrating into system tests to help keep this up to date and alert us when a whitelist is removed.