Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate tasks/{v2,v2beta2,v2beta3} to the PHP microgenerator #3972

Closed
wants to merge 7 commits into from
Closed

chore: migrate tasks/{v2,v2beta2,v2beta3} to the PHP microgenerator #3972

wants to merge 7 commits into from

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Apr 20, 2021 •
edited
Loading

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/bf04b530-c9fb-4052-8384-4e72442fc45e/targets

  • To automatically regenerate this PR, check this box. (May take up to 24 hours.)

PiperOrigin-RevId: 376845575
Source-Link: googleapis/googleapis@5908eff
PiperOrigin-RevId: 376172241
Source-Link: googleapis/googleapis@df616b5
PiperOrigin-RevId: 373698671
Source-Link: googleapis/googleapis@1b6fcb8
PiperOrigin-RevId: 372952726
Source-Link: googleapis/googleapis@b96db5a
PiperOrigin-RevId: 369318406
Source-Link: googleapis/googleapis@6bf9820

@yoshi-automation yoshi-automation requested a review from a team as a code owner April 20, 2021 10:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2021
@yoshi-automation
chore: migrate tasks/{v2,v2beta2,v2beta3} to the PHP microgenerator
0029b50 
Committer: @miraleung
PiperOrigin-RevId: 369318406

Source-Author: Google APIs <[email protected]>
Source-Date: Mon Apr 19 15:41:12 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 6bf9820eae19854b7269033bb1998d5f10cee8f5
Source-Link: googleapis/googleapis@6bf9820
@yoshi-automation
fix!: BREAKING_CHANGE: remove display_name from FeatureStore feat: ad…
20e01c6 
…d invalid_row_count to ImportFeatureValuesResponse and ImportFeatureValuesOperationMetadata

PiperOrigin-RevId: 372952726

Source-Author: Google APIs <[email protected]>
Source-Date: Mon May 10 10:02:01 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: b96db5aeb026e2c6f4fdeeacd8e5a2fc5fa14930
Source-Link: googleapis/googleapis@b96db5a
@yoshi-automation
feat!: migrate datastore/v1 to the PHP microgenerator
0781f10 
Committer: @miraleung
PiperOrigin-RevId: 373698671

Source-Author: Google APIs <[email protected]>
Source-Date: Thu May 13 18:21:24 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 1b6fcb897443c5de6060820e1de9c65b8c528471
Source-Link: googleapis/googleapis@1b6fcb8
@yoshi-automation
docs: fix grammar in documentation.
6fc4b09 
PiperOrigin-RevId: 376172241

Source-Author: Google APIs <[email protected]>
Source-Date: Thu May 27 08:17:40 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: df616b587f0b4302f15387f315c286035c3b8bb1
Source-Link: googleapis/googleapis@df616b5
@yoshi-automation
fix!: Specify namespace options for C# and PHP.
81a27a2 
This is only a breaking change for C# and PHP, which haven't published client libraries for this API yet.

PiperOrigin-RevId: 376845575

Source-Author: Google APIs <[email protected]>
Source-Date: Tue Jun 1 09:03:59 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 5908effa248111e0f8502e565dde541bee4f5de9
Source-Link: googleapis/googleapis@5908eff
@yoshi-automation yoshi-automation requested a review from a team as a code owner June 5, 2021 14:29
@google-cla
Copy link

google-cla bot commented Jun 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@dwsupplee dwsupplee changed the title [Tasks] chore: migrate tasks/{v2,v2beta2,v2beta3} to the PHP microgenerator chore: migrate tasks/{v2,v2beta2,v2beta3} to the PHP microgenerator Jun 8, 2021
@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 8, 2021
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 8, 2021
dwsupplee
dwsupplee reviewed Jun 8, 2021
View reviewed changes
Tasks/src/V2/Gapic/CloudTasksGapicClient.php
private static $locationNameTemplate;
private static $projectNameTemplate;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be retained.

@google-cla
Copy link

google-cla bot commented Sep 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 1, 2021
@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 10, 2021
@bshaffer
Copy link
Contributor

Superceded by #4883

@bshaffer bshaffer closed this Jan 25, 2022
@bshaffer bshaffer deleted the autosynth-tasks branch January 25, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee left review comments

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @bshaffer @dwsupplee @kokoro-team