Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation generation and contents #394

Merged
merged 4 commits into from
Mar 15, 2017
Merged

Fix documentation generation and contents #394

merged 4 commits into from
Mar 15, 2017

Conversation

jdpedrie
Copy link
Contributor

@jdpedrie jdpedrie commented Mar 14, 2017 •
edited
Loading

  • Generate full package documentation for main package (google-cloud)
  • Links in google-cloud package stay inside that package. Links in sub-packages to other packages cross the package boundary
  • Table of Contents in google-cloud lists everything, and inherits from sub-package TOC, making it easy to keep both synchronized.
  • Patterns guarantee that TOC sub-menus stay expanded as expected.
  • overview.html added to each package

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2017
@jdpedrie jdpedrie added documentation do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 14, 2017
@jdpedrie jdpedrie removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 14, 2017
dwsupplee
dwsupplee approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works beautifully on the docs site with this. Awesome work!

@jdpedrie jdpedrie merged commit 7a2218f into googleapis:master Mar 15, 2017
@jdpedrie jdpedrie deleted the generate-full-package-docs branch June 9, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpedrie @dwsupplee @googlebot