[BC Break] Remove paging from Subscription::pull #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jdpedrie
changed the title
jdpedrie
approved these changes
Mar 3, 2017
dwsupplee
force-pushed
the
pubsub-pull-remove-paging
branch
from
cb72ef9 to
1c9758f
Compare
jdpedrie
reviewed
Mar 3, 2017
| @@ -169,7 +170,7 @@ public function testPull() | |||
| $this->subscription->setConnection($this->connection->reveal()); | |||
|
|
|||
| $res = $snippet->invoke('messages'); | |||
| $this->assertInstanceOf(\Generator::class, $res->returnVal()); | |||
| $this->assertContainsOnlyInstancesOf(Message::class, $res->returnVal()); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't appear
pullsupports paging:https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/pull