Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tell github to always treat php files as text #3700

Closed
wants to merge 2 commits into from
Closed

fix: tell github to always treat php files as text #3700

wants to merge 2 commits into from

Conversation

SurferJeffAtGoogle
Copy link
Contributor

Speculative fix for googleapis/synthtool#918

@SurferJeffAtGoogle SurferJeffAtGoogle requested a review from a team as a code owner January 26, 2021 20:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@bshaffer
Copy link
Contributor

Seems like something that should be fixed in synthtool no?
I don't know the implications of setting the gitattribute. Ill have to do more research before approving.

@SurferJeffAtGoogle
fix: diff instead of text
586ced2 
Tell git to always attempt to diff php files, even if they're binary.
@SurferJeffAtGoogle
Copy link
Contributor Author

I think I found a better way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SurferJeffAtGoogle @bshaffer