-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stream wrapper for gs:// #323
Merged
Merged
Changes from 21 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
98cf841
Create Storage\StreamWrapper implementation that handles reads.
chingor13 5bff096
Fix php style guideline errors
chingor13 40ae470
Fix the remaining php coding standard errors.
chingor13 a9a5d08
Fix php 5.6 errors
chingor13 9f109ce
Fix travis errors
chingor13 e596ca9
Remove variadic from StreamableUploader. It is not compatible with ph…
chingor13 1e8f14c
Throw a RuntimeException instead of dying if the StreamWrapper fails …
chingor13 9e41cc3
Fix throwing of RuntimeException
chingor13 4dc989c
Move Storage namespaced functions to static methods on StorageClient.
chingor13 f8a3f19
Use static functions on StorageClient to get/set the default client.
chingor13 45a4641
StreamWrapper will maintain its default StorageClient as a static var…
chingor13 77d0d6e
Implement StorageClient#registerAsStreamWrapper().
chingor13 09a4ffe
Add documentation do StreamWrapper public functions
chingor13 18be73d
Catch ServiceExceptions instead of all GoogleExceptions
chingor13 41fcb84
Pass the original exception to the re-raised GoogleException when a s…
chingor13 2456d51
Fix stream wrapper checking array key for options
chingor13 435cc1e
check array_key_exists on reading options
chingor13 ba65eec
move codingStandardsIgnoreStart before the documentation for the stre…
chingor13 819e8b9
Fix documentation on registering a StorageClient as a stream wrapper.
chingor13 0c6944c
Fix building of docs for StreamWrapper class
chingor13 d86565b
Fix StreamWrapper loading of options from stream context in hhvm.
chingor13 52da349
Register the StorageClient with the protocol when registering a strea…
chingor13 0d7c111
Fix documentation for StreamWrapper getClient() and register()
chingor13 afa9463
Fix RuntimeException namespace
chingor13 54331aa
Remove getOption() which is no longer needed
chingor13 0947bcc
Declare StreamableUploader constructor parameters.
chingor13 22afe3d
Can't use string type hints with defaults for php5 and hhvm
chingor13 1f98977
Stream the read when using the StreamWrapper
chingor13 8547f8c
Fix code standard for test
chingor13 0adaa6c
Improve description of possible types for StreamableUploader#write()
chingor13 9d15b16
Fix README registerStreamWrapper()
chingor13 e06f6b5
Removing type hints for non-object types
chingor13 1bb0d3e
No need to lazy load or store options from context. Just read it once…
chingor13 06239b8
Namespace fixes to clean up code
chingor13 443cbf6
Implement mkdir, rmdir, unlink, url_stat callbacks. Adding tests for …
chingor13 6d9a37d
Need to get the size of the stream since we are streaming our reads f…
chingor13 0f99982
We don't need to implement stream_cast for now. It doesn't seem to ma…
chingor13 d3285bd
Implement the directory callbacks and seek
chingor13 dafddee
Implement rename
chingor13 4cccbe1
Fix CS for naming conventions
chingor13 9f08da9
Fix tests for rewinding a directory
chingor13 ab3a844
Handle the stream_open option flags. Add documentation about the allo…
chingor13 78ee793
Wrap download stream in a CachingStream if it must be seekable (getim…
chingor13 54adf94
Fix reference to debugging stream
chingor13 85da2f3
Fix code style for isSeekable
chingor13 082dfc3
Implement url_stat
chingor13 890f55d
Split buffering from the StreamableUploader into a WriteStream class …
chingor13 cd8ebfb
Add system tests for stream wrapper operations
chingor13 e0d4ea6
Fix image test
chingor13 a8c405a
Cannot use an array for constants
chingor13 5953f81
Fix unit tests to reflect mocks for refactored streams
chingor13 dd5ace8
Fixing system tests for url_stat for a directory without any files
chingor13 e520ba5
Fix codestyle indentation issues.
chingor13 9aa563d
Force our ReadStream to return the number of bytes requested.
chingor13 67f19f0
Documentation updates. Group private functions together.
chingor13 9d2cfd4
Add custom phpcs ruleset.
chingor13 c1b5371
Merge remote-tracking branch 'upstream/master' into gcs_stream_wrapper
chingor13 2fb8bb6
Updating docs for comments
chingor13 2b78220
ReadStream documentation updates
chingor13 7591391
Handle Service exceptions when listing directories
chingor13 f66c80a
rmdir now will attempt to delete the bucket if the path is '/'
chingor13 201d95f
Fix redefinition of method
chingor13 c2e8375
Put the rename function back which was accidentally stomped
chingor13 4826581
StreamWrapper can create the bucket and respect the specified mode.
chingor13 1b2654c
Handle service exceptions when renaming files/directories
chingor13 7bd960c
Can specify the chunkSize of the streaming upload via stream context.
chingor13 937541e
Bucket->isWritable will now expect a 403 access denied.
chingor13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.