Allow service definition path to be overridden by user #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jdpedrie
added
the
do not merge
|
@dwsupplee PTAL. System tests all passed on local run. |
|
The updates LGTM! Will merge once the build completes. |
dwsupplee
removed
the
do not merge
Merged
jdpedrie
added a commit
that referenced
this pull request
Feb 15, 2017
* Allow service definition path to be overridden by user * Remove the method, use config defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this change would allow users to supply their own Service Definition files for use with google-cloud-php.
When constructing a Client, or using a ServiceBuilder factory, supplying a param "serviceDefinitionPath" will override the default service definition file location.
This parameter is not documented currently. I think it would be a useful tool in some testing scenarios, and could be a potential stopgap solution for #287.