Added loggers for App Engine flexible environment. #28
Conversation
googlebot
added
the
cla: yes
| * @param Boolean $bubble Whether the messages that are handled can bubble up the stack or not. | ||
| * @param int|null $filePermission Optional file permissions (default (0640) are only for owner read/write). | ||
| * @param Boolean $useLocking Try to lock log file before doing any writes. | ||
| * @param resource|string $stream |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This looks good to me! Eventually we will be adding support for the logging API - I'm thinking once we get there we would use the namespace 'Logging' to keep consistent with the name of the service. What are your thoughts on that, do you think a 'Logger' and 'Logging' namespace would make sense, or could we house them under one? |
|
@dwsupplee First I have addressed your comments in the second commit. Yes, logging API library code should be under WDYT? |
|
That makes sense, sounds like it can work well to me |
|
I just squashed the commits. |
|
Can we have a tag for this? |
| @@ -26,6 +26,7 @@ | |||
| "google/auth": "0.7", | |||
| "guzzlehttp/guzzle": "~5.2|~6.0", | |||
| "guzzlehttp/psr7": "1.2.*", | |||
| "monolog/monolog": "~1", | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Fixes #9
This handler will format the logging message into a json format for a better presentation on the Cloud logging UI, in particular, with this format, you can filter the logs by severity, and also you should be able to bundle logs in a single request (unfortunately it doesn't work for me yet).
Downside is this PR adds monolog/monolog dependency. If you don't like big dependencies, please let me know. Potentially we can put these loggers in a different repo.