Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix breaking change in errorreporting gapic #2665

Merged
merged 1 commit into from
Feb 3, 2020
Merged

chore: fix breaking change in errorreporting gapic #2665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ErrorReporting/synth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,28 @@
r'Copyright \d{4}',
'Copyright 2018')

# fix renamed gapic formatting method.
s.replace(
'src/V1beta1/Gapic/ErrorGroupServiceGapicClient.php',
r'\/\*\*\n\s{5}\* Formats a string containing the fully-qualified path to represent\n\s{5}\* a error_group resource.',
"""/**
* Formats a string containing the fully-qualified path to represent
* an error_group resource.
*
* @deprecated use {@see Google\\\\Cloud\\\\ErrorReporting\\\\V1beta1\\\\Gapic\\\\ErrorGroupServiceGapicClient::errorGroupName()}.
* @param string $project
* @param string $group
* @return string the formatted error_group resource.
*/
public static function groupName($project, $group) {
return self::errorGroupName($project, $group);
}

/**
* Formats a string containing the fully-qualified path to represent
* a error_group resource."""
)

### [START] protoc backwards compatibility fixes

# roll back to private properties.
Expand Down