Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable 'FieldMask' param in Instance::reload() method options #2530

Merged
merged 4 commits into from
Jan 7, 2020
Merged

feat: enable 'FieldMask' param in Instance::reload() method options #2530

merged 4 commits into from
Jan 7, 2020

Conversation

AVaksman
Copy link
Contributor

Enabling FieldMask param in the getInstance call.
Link to proto

@AVaksman AVaksman requested a review from jdpedrie as a code owner December 26, 2019 04:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 26, 2019
@AVaksman AVaksman added the api: spanner Issues related to the Spanner API. label Dec 26, 2019
jdpedrie
jdpedrie suggested changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! couple minor things which I think are leftovers from earlier iterations where more processing was needed. we can get this approved really soon.

Spanner/src/Connection/Grpc.php Outdated Show resolved Hide resolved
Spanner/src/Instance.php Outdated Show resolved Hide resolved
Spanner/tests/Unit/Connection/GrpcTest.php Outdated Show resolved Hide resolved
@AVaksman AVaksman mentioned this pull request Jan 1, 2020
Closed
jdpedrie
jdpedrie approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdpedrie jdpedrie merged commit 006487a into googleapis:master Jan 7, 2020
This was referenced Jan 15, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 18, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 28, 2020
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Closed
This was referenced Feb 4, 2020
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@ava12 ava12 mentioned this pull request Feb 20, 2020
Merged
@yoshi-automation yoshi-automation mentioned this pull request Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AVaksman @jdpedrie @googlebot