Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bigquery destination, update GCS destination, support Real Time Feed API #2463

Merged
merged 4 commits into from
Dec 17, 2019
Merged

feat: add bigquery destination, update GCS destination, support Real Time Feed API #2463

merged 4 commits into from
Dec 17, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Log from Synthtool 
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/Asset/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
e80174c8b43b: Pulling fs layer
d1072db285cc: Pulling fs layer
858453671e67: Pulling fs layer
3d07b1124f98: Pulling fs layer
6d25889338d0: Pulling fs layer
01f1d5bcc1da: Pulling fs layer
3735ad9ac621: Pulling fs layer
a097f28e3b8b: Pulling fs layer
cf387d10331e: Pulling fs layer
675aa235e994: Pulling fs layer
b79e80db62d3: Pulling fs layer
d7d0b4ccb336: Pulling fs layer
147b4a1c03ba: Pulling fs layer
673cb74465a9: Pulling fs layer
096525f9a4d6: Pulling fs layer
5727b9cbc056: Pulling fs layer
54e662e7f6ec: Pulling fs layer
ab52fe701930: Pulling fs layer
dd87c42da981: Pulling fs layer
1a4261b7483f: Pulling fs layer
7b76a9d04639: Pulling fs layer
0c53e578fc65: Pulling fs layer
8809419949fa: Pulling fs layer
529341e3070a: Pulling fs layer
9d2ef27464e0: Pulling fs layer
6b674e3b45a2: Pulling fs layer
e7bdbde19b85: Pulling fs layer
a16eb44f6195: Pulling fs layer
ab52fe701930: Waiting
dd87c42da981: Waiting
1a4261b7483f: Waiting
7b76a9d04639: Waiting
0c53e578fc65: Waiting
01f1d5bcc1da: Waiting
3735ad9ac621: Waiting
a097f28e3b8b: Waiting
cf387d10331e: Waiting
675aa235e994: Waiting
8809419949fa: Waiting
529341e3070a: Waiting
9d2ef27464e0: Waiting
6b674e3b45a2: Waiting
e7bdbde19b85: Waiting
3d07b1124f98: Waiting
b79e80db62d3: Waiting
d7d0b4ccb336: Waiting
147b4a1c03ba: Waiting
673cb74465a9: Waiting
096525f9a4d6: Waiting
5727b9cbc056: Waiting
a16eb44f6195: Waiting
6d25889338d0: Waiting
54e662e7f6ec: Waiting
d1072db285cc: Verifying Checksum
d1072db285cc: Download complete
858453671e67: Verifying Checksum
858453671e67: Download complete
3d07b1124f98: Verifying Checksum
3d07b1124f98: Download complete
e80174c8b43b: Verifying Checksum
e80174c8b43b: Download complete
6d25889338d0: Verifying Checksum
6d25889338d0: Download complete
a097f28e3b8b: Verifying Checksum
a097f28e3b8b: Download complete
3735ad9ac621: Verifying Checksum
3735ad9ac621: Download complete
675aa235e994: Verifying Checksum
675aa235e994: Download complete
cf387d10331e: Verifying Checksum
cf387d10331e: Download complete
d7d0b4ccb336: Verifying Checksum
d7d0b4ccb336: Download complete
b79e80db62d3: Verifying Checksum
b79e80db62d3: Download complete
01f1d5bcc1da: Verifying Checksum
01f1d5bcc1da: Download complete
673cb74465a9: Verifying Checksum
673cb74465a9: Download complete
e80174c8b43b: Pull complete
d1072db285cc: Pull complete
5727b9cbc056: Verifying Checksum
5727b9cbc056: Download complete
858453671e67: Pull complete
096525f9a4d6: Verifying Checksum
096525f9a4d6: Download complete
3d07b1124f98: Pull complete
147b4a1c03ba: Verifying Checksum
147b4a1c03ba: Download complete
54e662e7f6ec: Download complete
ab52fe701930: Verifying Checksum
ab52fe701930: Download complete
dd87c42da981: Download complete
7b76a9d04639: Verifying Checksum
7b76a9d04639: Download complete
8809419949fa: Verifying Checksum
8809419949fa: Download complete
6d25889338d0: Pull complete
529341e3070a: Verifying Checksum
529341e3070a: Download complete
9d2ef27464e0: Verifying Checksum
9d2ef27464e0: Download complete
1a4261b7483f: Verifying Checksum
1a4261b7483f: Download complete
e7bdbde19b85: Verifying Checksum
e7bdbde19b85: Download complete
6b674e3b45a2: Verifying Checksum
6b674e3b45a2: Download complete
a16eb44f6195: Verifying Checksum
a16eb44f6195: Download complete
01f1d5bcc1da: Pull complete
3735ad9ac621: Pull complete
a097f28e3b8b: Pull complete
cf387d10331e: Pull complete
675aa235e994: Pull complete
b79e80db62d3: Pull complete
0c53e578fc65: Verifying Checksum
0c53e578fc65: Download complete
d7d0b4ccb336: Pull complete
147b4a1c03ba: Pull complete
673cb74465a9: Pull complete
096525f9a4d6: Pull complete
5727b9cbc056: Pull complete
54e662e7f6ec: Pull complete
ab52fe701930: Pull complete
dd87c42da981: Pull complete
1a4261b7483f: Pull complete
7b76a9d04639: Pull complete
0c53e578fc65: Pull complete
8809419949fa: Pull complete
529341e3070a: Pull complete
9d2ef27464e0: Pull complete
6b674e3b45a2: Pull complete
e7bdbde19b85: Pull complete
a16eb44f6195: Pull complete
Digest: sha256:545c758c76c3f779037aa259023ec3d1ef2d57d2c8cd00a222cb187d63ceac5e
Status: Downloaded newer image for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/asset/artman_cloudasset_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-asset-v1.
synthtool > Running generator for google/cloud/asset/artman_cloudasset_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-asset-v1beta1.
synthtool > Replaced "'serviceAddress' =>" in src/V1beta1/Gapic/AssetServiceGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/AssetServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1beta1/Gapic/AssetServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1/Gapic/AssetServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1beta1/Gapic/AssetServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/AssetServiceGapicClient.php.
synthtool > Replaced 'final class' in src/V1beta1/BatchGetAssetsHistoryResponse.php.
synthtool > Replaced 'final class' in src/V1beta1/ExportAssetsResponse.php.
synthtool > Replaced 'final class' in src/V1beta1/Asset.php.
synthtool > Replaced 'final class' in src/V1beta1/TimeWindow.php.
synthtool > Replaced 'final class' in src/V1beta1/OutputConfig.php.
synthtool > Replaced 'final class' in src/V1beta1/BatchGetAssetsHistoryRequest.php.
synthtool > Replaced 'final class' in src/V1beta1/GcsDestination.php.
synthtool > Replaced 'final class' in src/V1beta1/Resource.php.
synthtool > Replaced 'final class' in src/V1beta1/TemporalAsset.php.
synthtool > Replaced 'final class' in src/V1beta1/ExportAssetsRequest.php.
synthtool > Replaced 'final class' in src/V1/BatchGetAssetsHistoryResponse.php.
synthtool > Replaced 'final class' in src/V1/ExportAssetsResponse.php.
synthtool > Replaced 'final class' in src/V1/Asset.php.
synthtool > Replaced 'final class' in src/V1/TimeWindow.php.
synthtool > Replaced 'final class' in src/V1/OutputConfig.php.
synthtool > Replaced 'final class' in src/V1/BigQueryDestination.php.
synthtool > Replaced 'final class' in src/V1/BatchGetAssetsHistoryRequest.php.
synthtool > Replaced 'final class' in src/V1/GcsDestination.php.
synthtool > Replaced 'final class' in src/V1/Resource.php.
synthtool > Replaced 'final class' in src/V1/TemporalAsset.php.
synthtool > Replaced 'final class' in src/V1/ExportAssetsRequest.php.
synthtool > No replacements made in src/V*/**/*.php for pattern public function ([s|g]\w{3,})Unwrapped, maybe replacement is not longer needed?
synthtool > Replaced 'Copyright \\d{4}' in src/V1beta1/AssetServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1beta1/AssetServiceGrpcClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1beta1/Gapic/AssetServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1beta1/AssetServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1beta1/AssetServiceSmokeTest.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/AssetServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/AssetServiceGrpcClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/AssetServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/AssetServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/AssetServiceSmokeTest.php.
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: cloudasset Issues related to the Cloud Asset Inventory API. label Nov 14, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2019
@jdpedrie jdpedrie changed the title [CHANGE ME] Re-generated Asset to pick up changes in the API or client library generator. feat: add bigquery destination, update GCS destination Nov 14, 2019
jdpedrie
jdpedrie suggested changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRO mapping removal needs to be confirmed

@jdpedrie jdpedrie mentioned this pull request Nov 14, 2019
Closed
12 tasks
@dwsupplee
Copy link
Contributor

LRO mapping removal needs to be confirmed

I don't think this is intended, I'll investigate upstream.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 17, 2019
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 17, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@dwsupplee dwsupplee changed the title feat: add bigquery destination, update GCS destination feat: add bigquery destination, update GCS destination, support Real Time Feed API Dec 17, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 17, 2019
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 17, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 17, 2019
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 17, 2019
This was referenced Jan 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 28, 2020
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Closed
This was referenced Feb 4, 2020
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@yoshi-automation yoshi-automation mentioned this pull request Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @dwsupplee @googlebot @jdpedrie