Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update retry configurations and docs #2453

Merged
merged 2 commits into from
Nov 14, 2019
Merged

feat: update retry configurations and docs #2453

merged 2 commits into from
Nov 14, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Log from Synthtool
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/Iot/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:545c758c76c3f779037aa259023ec3d1ef2d57d2c8cd00a222cb187d63ceac5e
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/iot/artman_cloudiot.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-iot-v1.
synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/DeviceManagerGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1/Gapic/DeviceManagerGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/DeviceManagerGapicClient.php.
synthtool > Replaced 'final class' in src/V1/DeleteDeviceRegistryRequest.php.
synthtool > Replaced 'final class' in src/V1/UnbindDeviceFromGatewayResponse.php.
synthtool > Replaced 'final class' in src/V1/ListDeviceRegistriesRequest.php.
synthtool > Replaced 'final class' in src/V1/PublicKeyCredential.php.
synthtool > Replaced 'final class' in src/V1/HttpConfig.php.
synthtool > Replaced 'final class' in src/V1/RegistryCredential.php.
synthtool > Replaced 'final class' in src/V1/CreateDeviceRequest.php.
synthtool > Replaced 'final class' in src/V1/GetDeviceRegistryRequest.php.
synthtool > Replaced 'final class' in src/V1/CreateDeviceRegistryRequest.php.
synthtool > Replaced 'final class' in src/V1/PublicKeyCertificate.php.
synthtool > Replaced 'final class' in src/V1/ListDevicesRequest.php.
synthtool > Replaced 'final class' in src/V1/DeviceConfig.php.
synthtool > Replaced 'final class' in src/V1/ListDeviceConfigVersionsRequest.php.
synthtool > Replaced 'final class' in src/V1/DeviceState.php.
synthtool > Replaced 'final class' in src/V1/GatewayConfig.php.
synthtool > Replaced 'final class' in src/V1/MqttConfig.php.
synthtool > Replaced 'final class' in src/V1/BindDeviceToGatewayResponse.php.
synthtool > Replaced 'final class' in src/V1/ModifyCloudToDeviceConfigRequest.php.
synthtool > Replaced 'final class' in src/V1/UnbindDeviceFromGatewayRequest.php.
synthtool > Replaced 'final class' in src/V1/GatewayListOptions.php.
synthtool > Replaced 'final class' in src/V1/DeviceCredential.php.
synthtool > Replaced 'final class' in src/V1/GetDeviceRequest.php.
synthtool > Replaced 'final class' in src/V1/StateNotificationConfig.php.
synthtool > Replaced 'final class' in src/V1/DeviceRegistry.php.
synthtool > Replaced 'final class' in src/V1/EventNotificationConfig.php.
synthtool > Replaced 'final class' in src/V1/SendCommandToDeviceRequest.php.
synthtool > Replaced 'final class' in src/V1/DeleteDeviceRequest.php.
synthtool > Replaced 'final class' in src/V1/ListDeviceConfigVersionsResponse.php.
synthtool > Replaced 'final class' in src/V1/UpdateDeviceRequest.php.
synthtool > Replaced 'final class' in src/V1/UpdateDeviceRegistryRequest.php.
synthtool > Replaced 'final class' in src/V1/SendCommandToDeviceResponse.php.
synthtool > Replaced 'final class' in src/V1/ListDeviceStatesResponse.php.
synthtool > Replaced 'final class' in src/V1/ListDevicesResponse.php.
synthtool > Replaced 'final class' in src/V1/BindDeviceToGatewayRequest.php.
synthtool > Replaced 'final class' in src/V1/Device.php.
synthtool > Replaced 'final class' in src/V1/X509CertificateDetails.php.
synthtool > Replaced 'final class' in src/V1/ListDeviceRegistriesResponse.php.
synthtool > Replaced 'final class' in src/V1/ListDeviceStatesRequest.php.
synthtool > No replacements made in src/V*/**/*.php for pattern public function ([s|g]\w{3,})Unwrapped, maybe replacement is not longer needed?
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/DeviceManagerGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/DeviceManagerSmokeTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/DeviceManagerClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/DeviceManagerClientPartialVeneerTest.php.
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: cloudiot Issues related to the IoT Core API. label Nov 13, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2019
@@ -1173,9 +1173,9 @@ public function listDeviceStates($name, array $optionalArgs = [])
* ```
* $deviceManagerClient = new DeviceManagerClient();
* try {
* $formattedResource = $deviceManagerClient->registryName('[PROJECT]', '[LOCATION]', '[REGISTRY]');
* $resource = '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a documentation regression.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely related to the deprecation of the formatting methods, so should be expected.

Iot/src/V1/Gapic/DeviceManagerGapicClient.php Outdated Show resolved Hide resolved
@jdpedrie jdpedrie added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 13, 2019
@jdpedrie jdpedrie mentioned this pull request Nov 13, 2019
12 tasks
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 14, 2019
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 14, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jdpedrie jdpedrie added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2019
@jdpedrie jdpedrie changed the title [CHANGE ME] Re-generated Iot to pick up changes in the API or client library generator. feat: update clients Nov 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2019
@jdpedrie jdpedrie removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudiot Issues related to the IoT Core API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants