Update Translate API Client #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support service account and application default credentials in Translate * Add support for the new `model` field.
googlebot
added
the
cla: yes
jdpedrie
added
do not merge
|
LGTM, let others take a look also. |
akeran
reviewed
Nov 11, 2016
| @@ -50,7 +56,8 @@ public function testTranslate() | |||
| $options = [ | |||
| 'source' => $expected['source'], | |||
| 'target' => 'de', | |||
| 'format' => 'text' | |||
| 'format' => 'text', | |||
| 'model' => 'base' | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tmatsuo
reviewed
Nov 11, 2016
| @@ -134,6 +134,8 @@ public function __construct(array $config = []) | |||
| * @type string $format Indicates whether the string to be translated is | |||
| * either plain-text or HTML. Acceptable values are `html` or | |||
| * `text`. **Defaults to** `"html"`. | |||
| * @type string $model The model to use for the translation request. May | |||
| * be `nmt` or `base`. **Defaults to** an empty string. | |||
| * } | |||
| * @return array A translation result including a `source` key containing | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
reviewed
Nov 12, 2016
| * Please note that unlike most other Cloud Platform services Google Translate | ||
| * requires a public API access key and cannot currently be accessed with a | ||
| * service account or application default credentials. Follow the | ||
| * Please note that while Google Translate supports authentication via service |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -92,20 +90,22 @@ class TranslateClient | |||
| */ | |||
| public function __construct(array $config = []) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| $response = $this->connection->listTranslations($options + [ | ||
| 'q' => $strings, | ||
| 'key' => $this->key, | ||
| 'target' => $this->targetLanguage | ||
| 'target' => $this->targetLanguage, | ||
| 'model' => $options['model'] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| 'source' => $source, | ||
| 'input' => $strings[$key], | ||
| 'text' => $translation['translatedText'], | ||
| 'model' => (isset($translation['model'])) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Updated! PTAL @tmatsuo @dwsupplee @akeran |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please hold this until 11/15.
modelfield.Note that this change does not switch the operation from GET to POST.