Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update landmark image #2394

Merged
merged 1 commit into from
Oct 10, 2019
Merged

test: Update landmark image #2394

merged 1 commit into from
Oct 10, 2019

Conversation

dwsupplee
Copy link
Contributor

No description provided.

@dwsupplee dwsupplee requested a review from jdpedrie October 9, 2019 21:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2019
@dwsupplee dwsupplee added api: vision Issues related to the Cloud Vision API. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 9, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #2394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2394   +/-   ##
=========================================
  Coverage     92.55%   92.55%           
  Complexity     4503     4503           
=========================================
  Files           312      312           
  Lines         13497    13497           
=========================================
  Hits          12492    12492           
  Misses         1005     1005

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ced2a...5df405d. Read the comment docs.

jdpedrie
jdpedrie approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tired of having to constantly fix these system tests as the machine learning results evolve. Is there a way we could avoid asserting against specific results and just check that the expected values exist?

Approved nonetheless, just something to consider.

@dwsupplee
Copy link
Contributor Author

Agreed. I've been toying around with the idea of a bot that will open PRs to update ML system tests on our behalf across the googleapis repositories. Let me know if you're interested in building out the idea.

@dwsupplee dwsupplee merged commit a0a5e61 into googleapis:master Oct 10, 2019
This was referenced Jan 15, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Merged
@yoshi-automation yoshi-automation mentioned this pull request Feb 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwsupplee @jdpedrie @googlebot