-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to FirestoreSessionHandler #2360
Updates to FirestoreSessionHandler #2360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FirestoreTestCase function to delete $deletionQueue does not get registered. This is because the call do do this, which is in bootstrap.php, does not exist in system-bootstrap.php.
This is probably why so much junk piles up in the project! I'll look into that.
Remaining outstanding issues:
|
Codecov Report
@@ Coverage Diff @@
## master #2360 +/- ##
============================================
+ Coverage 92.53% 92.55% +0.01%
- Complexity 4501 4503 +2
============================================
Files 312 312
Lines 13479 13497 +18
============================================
+ Hits 12473 12492 +19
+ Misses 1006 1005 -1
Continue to review full report at Codecov.
|
There are still a few issues:
session_gc
returnsfalse
, even though the records get deleted as expected. I do not know why.FirestoreTestCase
function to delete$deletionQueue
does not get registered. This is because the call do do this, which is inbootstrap.php
, does not exist insystem-bootstrap.php
.