Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use latest artman version and remove final keyword #2274

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

dwsupplee
Copy link
Contributor

Closes: #2273 && #2272

@dwsupplee dwsupplee requested a review from jdpedrie August 28, 2019 18:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #2274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2274   +/-   ##
========================================
  Coverage      92.6%   92.6%           
  Complexity     4467    4467           
========================================
  Files           307     307           
  Lines         13323   13323           
========================================
  Hits          12338   12338           
  Misses          985     985

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a5dd0...55be18c. Read the comment docs.

OsLogin/synth.py Show resolved Hide resolved
Bigtable/synth.py Show resolved Hide resolved
Firestore/synth.py Show resolved Hide resolved
Spanner/synth.py Show resolved Hide resolved
@dwsupplee
Copy link
Contributor Author

Good eye :). Thanks @jdpedrie, PTAL - should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthesis failed for speech
3 participants