feat: Add apiEndpoint support to BigQuery and improve Translate basePath support. #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jdpedrie
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2241 +/- ##
============================================
+ Coverage 92.6% 92.61% +<.01%
- Complexity 4452 4455 +3
============================================
Files 307 307
Lines 13273 13282 +9
============================================
+ Hits 12292 12301 +9
Misses 981 981
Continue to review full report at Codecov.
|
dwsupplee
suggested changes
Aug 12, 2019
BigQuery/src/Connection/Rest.php
Outdated
| )); | ||
|
|
||
| $this->apiEndpoint = $config['apiEndpoint']; |
There was a problem hiding this comment.
Should this be using the end point returned from getApiEndpoint?
dwsupplee
approved these changes
Aug 14, 2019
This was referenced Jan 30, 2020
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.