Fix: Provide headers required for Firestore emulator. #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2239 +/- ##
===========================================
+ Coverage 92.6% 92.6% +<.01%
- Complexity 4451 4452 +1
===========================================
Files 307 307
Lines 13271 13273 +2
===========================================
+ Hits 12290 12292 +2
Misses 981 981
Continue to review full report at Codecov.
|
dwsupplee
approved these changes
Aug 8, 2019
|
Thanks @jdpedrie 😄 |
This was referenced Jan 30, 2020
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2197 by adding a dummy Authorization header to firestore requests when the emulator is enabled (as discussed here and here). Also allows custom headers to be passed to grpc calls in the Firestore client.