Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for apiEndpoint and deprecate serviceAddress client configuration option. #2222

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/Spanner/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
0.29.1: Pulling from googleapis/artman
Digest: sha256:b2a73f4dda03ef8fcaa973e3ba26d0cf34091f6c22c70add663af325931aef4d
Status: Image is up to date for googleapis/artman:0.29.1
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-spanner-v1.
synthtool > Replaced "'serviceAddress' =>" in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress' in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress' in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SpannerClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SpannerClientPartialVeneerTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/Admin/Instance/V1/InstanceAdminClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/Admin/Database/V1/DatabaseAdminClientTest.php.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-spanner-admin-database-v1.
synthtool > Replaced 'Copyright \\d{4}' in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/Admin/Database/V1/DatabaseAdminClientTest.php.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-spanner-admin-instance-v1.
synthtool > Replaced 'Copyright \\d{4}' in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/Admin/Instance/V1/InstanceAdminClientTest.php.
synthtool > No replacements made in src/V1/Gapic/SpannerGapicClient.php for pattern ExecuteSqlRequest_QueryMode, maybe replacement is not longer needed?
synthtool > No replacements made in src/V1/Gapic/SpannerGapicClient.php for pattern ExecuteBatchDmlRequest_Statement, maybe replacement is not longer needed?
synthtool > Replaced 'namespace Google\\\\Cloud\\\\Spanner\\\\Admin\\\\Database\\\\Tests\\\\Unit' in tests/Unit/Admin/Database/V1/DatabaseAdminClientTest.php.
synthtool > Replaced 'namespace Google\\\\Cloud\\\\Spanner\\\\Admin\\\\Instance\\\\Tests\\\\Unit' in tests/Unit/Admin/Instance/V1/InstanceAdminClientTest.php.
synthtool > Replaced '@group database' in tests/Unit/Admin/Database/V1/DatabaseAdminClientTest.php.
synthtool > Replaced '@group instance' in tests/Unit/Admin/Instance/V1/InstanceAdminClientTest.php.
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: spanner Issues related to the Spanner API. label Aug 7, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2019
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #2222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2222   +/-   ##
========================================
  Coverage      92.6%   92.6%           
  Complexity     4451    4451           
========================================
  Files           307     307           
  Lines         13271   13271           
========================================
  Hits          12290   12290           
  Misses          981     981

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d532d77...c11fba5. Read the comment docs.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 7, 2019
@jdpedrie jdpedrie changed the title [CHANGE ME] Re-generated Spanner to pick up changes in the API or client library generator. feat: Add support for apiEndpoint and deprecate serviceAddress client configuration option. Aug 7, 2019
@jdpedrie jdpedrie force-pushed the autosynth-spanner branch from 4376771 to c11fba5 Compare August 7, 2019 19:42
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 7, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants