Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for apiEndpoint and deprecate serviceAddress client configuration option. #2217

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/OsLogin/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
0.29.1: Pulling from googleapis/artman
Digest: sha256:b2a73f4dda03ef8fcaa973e3ba26d0cf34091f6c22c70add663af325931aef4d
Status: Image is up to date for googleapis/artman:0.29.1
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/oslogin/artman_oslogin_v1beta.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-os-login-v1beta.
synthtool > Running generator for google/cloud/oslogin/artman_oslogin_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-os-login-v1.
synthtool > Replaced "'serviceAddress' =>" in src/V1beta/Gapic/OsLoginServiceGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/OsLoginServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress' in src/V1beta/Gapic/OsLoginServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress' in src/V1/Gapic/OsLoginServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1beta/Gapic/OsLoginServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/OsLoginServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1beta/OsLoginServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1beta/OsLoginServiceGrpcClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1beta/Gapic/OsLoginServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1beta/OsLoginServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1beta/OsLoginServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/OsLoginServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/OsLoginServiceGrpcClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/OsLoginServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/OsLoginServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/OsLoginServiceClientTest.php.
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: oslogin Issues related to the Cloud OS Login API API. label Aug 7, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2019
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2a8a0c4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2217   +/-   ##
========================================
  Coverage          ?   92.6%           
  Complexity        ?    4451           
========================================
  Files             ?     307           
  Lines             ?   13271           
  Branches          ?       0           
========================================
  Hits              ?   12290           
  Misses            ?     981           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8a0c4...3dfb4d0. Read the comment docs.

@jdpedrie jdpedrie changed the title [CHANGE ME] Re-generated OsLogin to pick up changes in the API or client library generator. feat: Add support for apiEndpoint and deprecate serviceAddress client configuration option. Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: oslogin Issues related to the Cloud OS Login API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants