Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (storage) support for uniform bucket-level access #2146

Merged
merged 6 commits into from
Nov 4, 2019
Merged

feat: (storage) support for uniform bucket-level access #2146

merged 6 commits into from
Nov 4, 2019

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Jul 27, 2019 •
edited
Loading

  • Update integration tests to use uniform bucket-level access instead.
  • Update documentation.
  • Review from GCS eng team(@thanhld94).
  • Fix pending for backend bug: 134695162. Remove workaround.
  • Update discovery document to latest version.

@frankyn frankyn added api: storage Issues related to the Cloud Storage API. needs work This is a pull request that needs a little love. labels Jul 27, 2019
@frankyn frankyn requested a review from dwsupplee as a code owner July 27, 2019 07:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2019
@codecov
Copy link

codecov bot commented Jul 27, 2019 •
edited
Loading

Codecov Report

Merging #2146 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2146      +/-   ##
============================================
- Coverage     92.55%   92.47%   -0.08%     
+ Complexity     4504     4477      -27     
============================================
  Files           312      312              
  Lines         13496    13416      -80     
============================================
- Hits          12491    12407      -84     
- Misses         1005     1009       +4
Impacted Files Coverage Δ Complexity Δ
Storage/src/StorageClient.php 100% <ø> (ø) 31 <0> (ø) ⬇️
Storage/src/Bucket.php 97.18% <ø> (ø) 70 <0> (ø) ⬇️
Translate/src/Connection/Rest.php 0% <0%> (-100%) 0% <0%> (-4%)
Translate/src/TranslateClient.php
Translate/src/Connection/ConnectionInterface.php 0% <0%> (ø) 0% <0%> (?)
Firestore/src/Query.php 99.2% <0%> (ø) 86% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b90be0...745c2ac. Read the comment docs.

@frankyn frankyn mentioned this pull request Oct 10, 2019
Merged
dwsupplee and others added 4 commits October 25, 2019 13:42
@dwsupplee @JesseLovelace
fix: close code snippet (#2140)
1c41b33
@yoshi-automation @JesseLovelace
chore: release 0.106.1 (#2142)
eb6f26d 
* updated Spanner/VERSION [ci skip]

* updated Spanner/src/SpannerClient.php [ci skip]

* updated composer.json [ci skip]

* updated docs/manifest.json [ci skip]

* updated CHANGELOG.md [ci skip]

* updated src/Version.php [ci skip]

* updated src/ServiceBuilder.php [ci skip]
@yoshi-automation @JesseLovelace
docs: Update SpeakerDiarizationConfig documentation. (#2144)
da6f263
@frankyn @JesseLovelace
feat: support uniform bucket-level access
441df9c
@frankyn frankyn requested a review from jdpedrie as a code owner October 25, 2019 20:44
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 25, 2019
@JesseLovelace JesseLovelace changed the title [WIP] [Storage] Support for uniform bucket-level access. feat: (storage) support for uniform bucket-level access. Oct 25, 2019
@JesseLovelace JesseLovelace changed the title feat: (storage) support for uniform bucket-level access. feat: (storage) support for uniform bucket-level access Oct 25, 2019
@JesseLovelace JesseLovelace added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Oct 28, 2019
@frankyn
Copy link
Member Author

frankyn commented Oct 30, 2019

Hi @jdpedrie,

Could you help update the service definition for this change? I lost permission to write to this branch since I first started it. I'll look into it. In the mean time is this something you can pick up? I believe it's the last thing remaining.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 30, 2019
@jdpedrie
Copy link
Contributor

@frankyn sure thing! pushed.

@frankyn
Copy link
Member Author

frankyn commented Oct 30, 2019

Thank you!

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Oct 31, 2019
@jdpedrie
Copy link
Contributor

jdpedrie commented Nov 1, 2019

@frankyn to confirm, are you ready for this to be merged?

frankyn
frankyn commented Nov 1, 2019
View reviewed changes
Copy link
Member Author

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't explicitly approve but LGTM!

@frankyn
Copy link
Member Author

frankyn commented Nov 4, 2019

Please merge/release when ready.

@dwsupplee dwsupplee removed the needs work This is a pull request that needs a little love. label Nov 4, 2019
@dwsupplee dwsupplee merged commit b48d791 into master Nov 4, 2019
@jdpedrie jdpedrie deleted the ubla branch November 4, 2019 17:57
This was referenced Jan 15, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Merged
@yoshi-automation yoshi-automation mentioned this pull request Feb 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseLovelace JesseLovelace JesseLovelace approved these changes

@thanhld94 thanhld94 thanhld94 approved these changes

@dwsupplee dwsupplee dwsupplee approved these changes

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@frankyn @googlebot @jdpedrie @dwsupplee @thanhld94 @JesseLovelace @yoshi-automation