introduce gRPC support for pub/sub #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
force-pushed
the
grpc-pubsub
branch
from
0c65e5e to
33bbfa9
Compare
dwsupplee
force-pushed
the
grpc-pubsub
branch
from
fba150b to
591a32c
Compare
jdpedrie
reviewed
Oct 17, 2016
| return $response->serialize(new PhpArray()); | ||
| } | ||
|
|
||
| return []; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -18,6 +18,8 @@ | |||
| namespace Google\Cloud\PubSub; | |||
|
|
|||
| use Google\Cloud\ClientTrait; | |||
| use Google\Cloud\Exception\GoogleException; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -119,35 +99,24 @@ class RequestWrapper | |||
| * @type int $retries Number of retries for a failed request. | |||
| * **Defaults to** `3`. | |||
| * @type array $scopes Scopes to be used for the request. | |||
| * @type boolean $shouldSignRequest Whether to enable request signing. | |||
| * @type bool $shouldSignRequest Whether to enable request signing. | |||
| * } | |||
| */ | |||
| public function __construct(array $config = []) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * {@see Google\Cloud\ServiceBuilder::__construct()} for the available options. | ||
| * @param array $config [optional] { | ||
| * Configuration options. See | ||
| * {@see Google\Cloud\ServiceBuilder::__construct()} for the other available options. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Great work pal! |
|
Updated! PTAL @jdpedrie |
|
@dwsupplee feel free to merge once Travis is done. I probably will be afk before CI is finished. :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we now officially have gRPC support for pub/sub!
Perform the following installation:
... and the pub/sub client should automatically detect you are capable of using gRPC and enable that as the transport mechanism.
You can also toggle between REST/gRPC by providing the
transportoption when building your pub/sub client.