Queries now STOP once the limit has been reached. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
reviewed
Oct 11, 2016
| @@ -405,7 +405,7 @@ public function runQuery(QueryInterface $query, array $options = []) | |||
| yield $result; | |||
| } | |||
|
|
|||
| if ($query->canPaginate() && $res['batch']['moreResults'] !== 'NO_MORE_RESULTS') { | |||
| if ($query->canPaginate() && $res['batch']['moreResults'] === 'NOT_FINISHED') { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
approved these changes
Oct 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantically, limiting query results should be a hard limit rather than a results-per-page limit. This change will cause
Operation::runQuery()to respect limits and endCursors rather than continuing past the limits set by the user.Once improvements to the Iterator are released, we should return the endCursor to the user along with the moreResultsType value (i.e.
MORE_RESULTS_AFTER_LIMIT,MORE_RESULTS_AFTER_CURSOR) and allow them to fetch as they see fit.