Retry fixes #1815
Merged
Retry fixes #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwsupplee
added
api: bigquery
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1815 +/- ##
============================================
+ Coverage 91.53% 91.53% +<.01%
- Complexity 4360 4371 +11
============================================
Files 304 304
Lines 12901 12914 +13
============================================
+ Hits 11809 11821 +12
- Misses 1092 1093 +1
Continue to review full report at Codecov.
|
jdpedrie
approved these changes
Apr 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1813, #1809
Big thanks to @paslandau for the reports! The
BigQueryClientwas incorrectly using therestDelayFunctionto attempt to override the exponential delay calculation. This exposes a new option (restCalcDelayFunction) which allows this behavior to work as expected. Additionally, this addresses an issue when attempting to retry error messages sourced from guzzle exceptions.