Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate language v1 #1794

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Generate language v1 #1794

merged 4 commits into from
Apr 2, 2019

Conversation

dwsupplee
Copy link
Contributor

No description provided.

@dwsupplee dwsupplee added the api: language Issues related to the Cloud Natural Language API API. label Apr 1, 2019
@dwsupplee dwsupplee requested a review from jdpedrie April 1, 2019 16:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2019
jdpedrie
jdpedrie reviewed Apr 1, 2019
View reviewed changes
docs/contents/cloud-language.json
@@ -11,6 +11,16 @@
}, {
"title": "Annotation",
"type": "language/annotation"
}, {
"title": "v1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should standardize to this format or to the one we've used recently as illustrated here? Seems odd to be moving forward with varying formats.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we will standardize when we deprecate the manually written classes 👍

jdpedrie
jdpedrie approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, otherwise lgtm.

@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@codecov
Copy link

codecov bot commented Apr 1, 2019 •
edited
Loading

Codecov Report

Merging #1794 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1794   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179eb0c...0c0eea4. Read the comment docs.

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 1, 2019
@jdpedrie jdpedrie added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2019
@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #1794 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1794   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179eb0c...0c0eea4. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #1794 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1794   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179eb0c...0c0eea4. Read the comment docs.

@dwsupplee
Copy link
Contributor Author

I'm going to merge this, I think the CI is just having a bad day.

@dwsupplee dwsupplee merged commit 43db352 into googleapis:master Apr 2, 2019
@jdpedrie jdpedrie mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: language Issues related to the Cloud Natural Language API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dwsupplee @codecov-io @jdpedrie @googlebot @kokoro-team