Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial generation of SecurityCenter #1735

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Initial generation of SecurityCenter #1735

merged 3 commits into from
Apr 2, 2019

Conversation

dwsupplee
Copy link
Contributor

@dwsupplee dwsupplee commented Mar 19, 2019 •
edited by jdpedrie
Loading

Todo:

  • Add sample to READMEs
  • Add to docs site
  • PHPUnit configs

@dwsupplee dwsupplee added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: securitycenter Issues related to the Security Command Center API. labels Mar 19, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2019
@codecov
Copy link

codecov bot commented Mar 19, 2019 •
edited
Loading

Codecov Report

Merging #1735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1735   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1783a...693c708. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 26, 2019
@dwsupplee dwsupplee added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Mar 27, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 2, 2019
@jdpedrie jdpedrie removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. needs work This is a pull request that needs a little love. labels Apr 2, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 2, 2019
@dwsupplee dwsupplee changed the title WIP - Initial generation of SecurityCenter Initial generation of SecurityCenter Apr 2, 2019
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed 🚨 This issue needs some love. cla: no This human has *not* signed the Contributor License Agreement. labels Apr 2, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

Codecov Report

Merging #1735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1735   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1783a...693c708. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #1735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1735   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1783a...693c708. Read the comment docs.

@dwsupplee dwsupplee merged commit 09dd83d into googleapis:master Apr 2, 2019
@jdpedrie jdpedrie mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: securitycenter Issues related to the Security Command Center API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dwsupplee @googlebot @codecov-io @jdpedrie @yoshi-automation