Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add talent solution library #1665

Merged
merged 4 commits into from
Feb 6, 2019
Merged

Conversation

dwsupplee
Copy link
Contributor

No description provided.

@dwsupplee dwsupplee added the api: talent talent.googleapis.com (DO NOT CHANGE LABEL NAME) label Feb 5, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2019
README.md Outdated Show resolved Hide resolved
Talent/README.md Show resolved Hide resolved
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 5, 2019
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 5, 2019
@dwsupplee
Copy link
Contributor Author

Updated. PTAL

@jdpedrie
Copy link
Contributor

jdpedrie commented Feb 6, 2019

We need a phpunit.xml.dist file, and perhaps a system test/system test config? Otherwise, everything looks to be in order. :)

@dwsupplee
Copy link
Contributor Author

I added the phpunit config (would we be able to get the addition of that included in the google-cloud CLI tool?).

As for the System tests, since this is alpha we can follow up with those a bit later.

@dwsupplee dwsupplee merged commit 518a64c into googleapis:master Feb 6, 2019
@jdpedrie jdpedrie mentioned this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: talent talent.googleapis.com (DO NOT CHANGE LABEL NAME) cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants