Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firestore V1 generated client #1631

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Add Firestore V1 generated client #1631

merged 3 commits into from
Jan 29, 2019

Conversation

jdpedrie
Copy link
Contributor

No description provided.

@jdpedrie jdpedrie added the api: firestore Issues related to the Firestore API. label Jan 28, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2019
dwsupplee
dwsupplee suggested changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add V1 to docs/contents/cloud-firestore.json?

@jdpedrie
Copy link
Contributor Author

@dwsupplee done!

@jdpedrie jdpedrie mentioned this pull request Jan 29, 2019
Merged
@dwsupplee dwsupplee merged commit 3663c9b into googleapis:master Jan 29, 2019
@jdpedrie jdpedrie mentioned this pull request Feb 6, 2019
Merged
@jdpedrie jdpedrie deleted the firestore-gen-v1 branch April 9, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpedrie @dwsupplee @googlebot