Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup references to non-existant firestore conformance fixtures #1418

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Cleanup references to non-existant firestore conformance fixtures #1418

merged 1 commit into from
Nov 9, 2018

Conversation

dwsupplee
Copy link
Contributor

@jdpedrie can you please confirm this change is safe? :)

@dwsupplee dwsupplee added the api: firestore Issues related to the Firestore API. label Nov 9, 2018
@dwsupplee dwsupplee requested a review from jdpedrie November 9, 2018 22:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2018
jdpedrie
jdpedrie approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. :)

@dwsupplee dwsupplee merged commit 11b4db7 into googleapis:master Nov 9, 2018
@dwsupplee dwsupplee deleted the firestore-cleanup branch November 9, 2018 23:29
jdpedrie added a commit that referenced this pull request Nov 12, 2018
@jdpedrie
Revert "Cleanup references to non-existant firestore conformance fixt…
b465592 
…ures (#1418)"

This reverts commit 11b4db7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwsupplee @jdpedrie @googlebot