Bigtable: Read rows filter #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sduskis
added
api: bigtable
|
@dwsupplee, can you please review this? |
|
Yes, my review/updates are in process. I'll be pushing a PR to Ajay's fork shortly with any updates similar to the read rows work. |
|
@dwsupplee, @ajaaym: what's the latest on this? |
|
Apologies for the delay, I'll have my changes pushed up by EOD. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googlebot
added
cla: no
ajaaym
force-pushed
the
read_rows_filter
branch
from
073e057 to
fa4f206
Compare
|
@dwsupplee I moved builder for filter in to its own namespace. Can you please review? |
|
@ajaaym this is looking great, thanks for adding the snippet tests! |
dwsupplee
approved these changes
Sep 28, 2018
dwsupplee
added a commit
that referenced
this pull request
Nov 5, 2018
* Bigtable data operation mutate rows (#1230) * mutate rows * Fixed type in comment * Bigtable Mutate rows optional parameter (#1233) * add mutate rows optional configuration parameter * update order of append operation * Bigtable data read rows (#1234) * read rows * read rows acceptance test * fix type in parameter * fix param type in comment * Fix the state value * fix error in php5.5 * fix for protobuf extension * fix doc issue * review updates * fix rows->readAll * fix cs * Bigtable: Read rows filter (#1253) * read rows filter * fix test case * Filter * add comments * add espace for literal regex * Fix failing test * add snippet test * Fix doc * code review updates * moved builder in to its own namespace * add snippet test * arrange use statement * fix failing test case * Fix documentation * Readrows Filter and system test (#1322) * System test for filter * update doc * throw exception if rowKeys is not array in readRows * Simplified some fitler test * use dataprovider for filter system test * formatting * address feedback * Provide test name in message for conformance test (#1332) * provide message for failed test * update message * Bigtable: Read modify write row model (#1334) * readModifyWriteRowRule model * read modify write row * read modify write row api * update comments * fix static initializer * fix exception check for php < 7 * fix test case * update pack and unpack for php5.5 * address feedback * fix php 5.5 snippet test case * update doc and check * address feedback * Bigtable: Sample row keys api (#1338) * sample row keys * sample row keys * fix system test case * address feedback * fix snippet test * Bigtable: checkAndMutateRow api implementation (#1333) * checkAndMutateRow api * fix doc * fix snippet test * change snippet test * address feedback * update note * update comment * apply note to truemutations * fix comment * fix snippet test * Bigtable: refactor mutation model (#1367) * refactor mutation model * fix doc comment * address feedback * use ternary operator * fix comment * mutateRow api (#1382) * Rename DataClient -> Table and add BigtableClient (#1387) * rename DataClient to Table and add generic constructor options * update documentation * update snippets * update and rename system tests * update unit tests * add projectId/credentials to client * update mutateRow * update mutateRow system test * add imports for documentation * fix tests * potential fix for hhvm * fix projectId * Prep Bigtable handwritten client for release (#1388) * prepare bigtable handwritten layer for release * fix trailing comma * Update readme/projectID detection (#1391) * add note about differences in handwritten client * update projectID detection (we cannot reliably use the ClientTrait with the new client configuration options) * remove ClientTrait * add note on providing a keyfile * add note about authentication * Add 64 or 32 bit test (#1393) * Add 64 or 32 bit test * remove test annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read rows filter implementation for Bigtable.
@jdpedrie @dwsupplee @sduskis Can you please provide feedback?