Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining conformance tests for Firestore. #1207

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Implement remaining conformance tests for Firestore. #1207

merged 2 commits into from
Aug 20, 2018

Conversation

jdpedrie
Copy link
Contributor

@jdpedrie jdpedrie commented Aug 7, 2018

No description provided.

@jdpedrie jdpedrie added the api: firestore Issues related to the Firestore API. label Aug 7, 2018
@jdpedrie jdpedrie requested a review from dwsupplee August 7, 2018 19:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2018
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor notes, the changes overall seem to make sense.


/**
* @var array
*/
private $fieldNames;

/**
* @param array $fieldNames A list of field names.
*/

This comment was marked as spam.


$fieldPath = implode('.', $out);

$this->validateString($fieldPath);

This comment was marked as spam.

throw new \InvalidArgumentException('Cannot delete fields when creating a document.');
}

if ($flags['timestampInArray']) {
throw new \InvalidArgumentException(

This comment was marked as spam.

list ($fields, $sentinels, $flags) = $this->filterFields($fields);

if (!$merge && $sentinels[FieldValue::deleteField()]) {
throw new \InvalidArgumentException('Delete cannot appear in data unless `$options[\'merge\']` is set.');

This comment was marked as spam.

@jdpedrie jdpedrie merged commit b466186 into googleapis:master Aug 20, 2018
@jdpedrie jdpedrie deleted the firestore-conformance branch August 20, 2018 16:01
@jdpedrie jdpedrie mentioned this pull request Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants