Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Firestore system test artifacts #1117

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Cleanup Firestore system test artifacts #1117

merged 1 commit into from
Jun 26, 2018

Conversation

jdpedrie
Copy link
Contributor

This change fixes an issue where if system test artifacts remain, the next test run will fail.

All test collections are uniquely named and will not conflict with previous test executions. Additionally, the cleanup process has been improved to make it simpler to be sure all artifacts are removed upon test completion.

@jdpedrie jdpedrie added the api: firestore Issues related to the Firestore API. label Jun 21, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2018
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 👍

@dwsupplee dwsupplee merged commit c858f6c into googleapis:master Jun 26, 2018
@jdpedrie jdpedrie deleted the firestore-querytest-system branch June 26, 2018 19:36
@jdpedrie jdpedrie mentioned this pull request Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants