Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing $optind variable #1104

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Removing $optind variable #1104

merged 1 commit into from
Jun 14, 2018

Conversation

gabidavila
Copy link
Contributor

On our documentation we say PHP 7.0 is necessary to use Stackdriver, however this debugger library uses the $optind parameter for getopt, said parameter was only added on 7.1 and it throws a Fatal error when using with PHP 7.0.

This PR removes it since it's not being used to keep the library compatible with 7.0

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2018
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@dwsupplee dwsupplee merged commit 294bfde into googleapis:master Jun 14, 2018
@jdpedrie jdpedrie mentioned this pull request Jun 19, 2018
jdpedrie added a commit that referenced this pull request Jun 20, 2018
## Google Cloud PHP v0.69.0

### google/cloud-debugger v0.12.0

* Cloud Debugger limits the amount of data captured for snapshots by default. Several new configuration options have been added to {@see Google\Cloud\Debugger\Agent::__construct()} to allow control over these new defaults. (#1099)
* Fixed a bug where a debuggee may not register properly. (#1102)
* Fixed a bug where Stackdriver Debugger was not compatible with PHP 7.0. (#1104)

### google/cloud-logging v1.12.1

* Added missing passthrough options in {@see Google\Cloud\Logging\LoggingClient::psrLogger()} and fixed object serialization. (#1110)

### google/cloud-videointelligence v1.0.0

* There are no code changes since our last release, but we are proud to now announce our support of Cloud Video Intelligence at a GA level. This means that we do not expect to introduce any breaking changes and that we believe the library is ready for production use. For more information on our versioning please see [here](https://github.com/GoogleCloudPlatform/google-cloud-php#versioning).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants