-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC - Simplify GAPIC options #899
RFC - Simplify GAPIC options #899
Conversation
* A CredentialsLoader object created using the Google\Auth library. | ||
* Options for configuring the service API wrapper. | ||
* | ||
* @type string $serviceAddress The address of the API remote host. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* @type string[] $scopes A string array of scopes to use when acquiring credentials. | ||
* Defaults to the scopes for the Google Cloud Pub/Sub API. | ||
* Defaults to the scopes for the Google Cloud Pub/Sub API. | ||
* @type array $keyFile The contents of the service account credentials |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* signature of `function (RequestInterface $request, array $options) : PromiseInterface`. | ||
* NOTE: This option is only valid when utilizing the REST transport. | ||
* in the resources folder. | ||
* @type bool $disableRetries Determines whether or not retries defined |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* @type callable $authHttpHandler A handler used to deliver PSR-7 requests specifically | ||
* for authentication. Should match a signature of | ||
* `function (RequestInterface $request, array $options) : ResponseInterface`. | ||
* @type callable $httpHandler A handler used to deliver PSR-7 requests. Should match a |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
/cc @bshaffer, @jdpedrie, @michaelbausor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Cutting down on those options is a huge win.
* A CredentialsLoader object created using the Google\Auth library. | ||
* Options for configuring the service API wrapper. | ||
* | ||
* @type string $serviceAddress The address of the API remote host. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* @type string[] $scopes A string array of scopes to use when acquiring credentials. | ||
* Defaults to the scopes for the Google Cloud Pub/Sub API. | ||
* Defaults to the scopes for the Google Cloud Pub/Sub API. | ||
* @type array $keyFile The contents of the service account credentials |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* signature of `function (RequestInterface $request, array $options) : PromiseInterface`. | ||
* NOTE: This option is only valid when utilizing the REST transport. | ||
* in the resources folder. | ||
* @type bool $disableRetries Determines whether or not retries defined |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* @type callable $authHttpHandler A handler used to deliver PSR-7 requests specifically | ||
* for authentication. Should match a signature of | ||
* `function (RequestInterface $request, array $options) : ResponseInterface`. | ||
* @type callable $httpHandler A handler used to deliver PSR-7 requests. Should match a |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Source-Link: googleapis/googleapis@55499b5 Source-Link: googleapis/googleapis-gen@cf5049b Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiY2Y1MDQ5YjcwNzkyODIwMDY1ZGIzOGU3MTI3ZjMyZWFiNzcwNTk0NCJ9
* feat: Update Compute Engine API to revision 20240407 (#890) Source-Link: googleapis/googleapis@018c0e3 Source-Link: googleapis/googleapis-gen@dad8476 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiZGFkODQ3NmM5NGViMWVjYjJmZDcyZjI5NjgyNWU5NjIxZWE4YjQ1ZCJ9 * feat: Update Compute Engine API to revision 20240421 (#899) Source-Link: googleapis/googleapis@55499b5 Source-Link: googleapis/googleapis-gen@cf5049b Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiY2Y1MDQ5YjcwNzkyODIwMDY1ZGIzOGU3MTI3ZjMyZWFiNzcwNTk0NCJ9
Using this as a place to house discussion on simplifying options on the GAPICs (and eventually the handwritten veneers, pending a decision on whether we will be using GAPICs powered by the discovery docs for current non-GAPIC based clients).