-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use google-auth-library #2
Comments
googleapis/google-auth-library-php#84 helps get us on track with this |
The changes were merged into master, closing this out. |
dwsupplee
pushed a commit
that referenced
this issue
Feb 22, 2017
* Create Storage\StreamWrapper implementation that handles reads. Add StreamWrapper registration instructions to README. Add ability to register/unregister the StreamWrapper. first stab at a StreamingUploader class Refactor uploader Add bucket->getStreamableUploader() Can pass storage options to the uploader and downloader streams via the stream context move register functions into the Storage namespace, autoloaded by composer add StreamingUploaderTest cannot lazy load because we need to know if the file open succeeded rename StreamingUploader to StreamableUploader to match convention Add test for StreamableUploader to test batching Add documentation for Bucket#getStreamableUploader with example. Adding tests for StreamWrapper with the most common use cases. Fix README with the correct usage * Fix php style guideline errors * Fix the remaining php coding standard errors. The method names need to be underscored instead of camel case because they are the callback methods needed to implement a stream wrapper. * Fix php 5.6 errors * Fix travis errors * Remove variadic from StreamableUploader. It is not compatible with php 5.5 * Throw a RuntimeException instead of dying if the StreamWrapper fails to register * Fix throwing of RuntimeException * Move Storage namespaced functions to static methods on StorageClient. * Use static functions on StorageClient to get/set the default client. Add a test for overriding the StorageClient in a stream wrapper via the context. * StreamWrapper will maintain its default StorageClient as a static variable. * Implement StorageClient#registerAsStreamWrapper(). Enables handling streams with that StorageClient instance as the default StorageClient. * Add documentation do StreamWrapper public functions * Catch ServiceExceptions instead of all GoogleExceptions * Pass the original exception to the re-raised GoogleException when a streaming upload fails * Fix stream wrapper checking array key for options * check array_key_exists on reading options * move codingStandardsIgnoreStart before the documentation for the stream handler callback functions. * Fix documentation on registering a StorageClient as a stream wrapper. * Fix building of docs for StreamWrapper class * Fix StreamWrapper loading of options from stream context in hhvm. In hhvm, you cannot get options from a null context. * Register the StorageClient with the protocol when registering a stream wrapper * Fix documentation for StreamWrapper getClient() and register() * Fix RuntimeException namespace * Remove getOption() which is no longer needed * Declare StreamableUploader constructor parameters. Declare $buffer visibility. * Can't use string type hints with defaults for php5 and hhvm * Stream the read when using the StreamWrapper * Fix code standard for test * Improve description of possible types for StreamableUploader#write() * Fix README registerStreamWrapper() * Removing type hints for non-object types * No need to lazy load or store options from context. Just read it once when it's needed (at stream_open time). * Namespace fixes to clean up code * Implement mkdir, rmdir, unlink, url_stat callbacks. Adding tests for these and directory operations, rename, stream_cast * Need to get the size of the stream since we are streaming our reads from http * We don't need to implement stream_cast for now. It doesn't seem to make sense for trying to stream_select on a gs:// path * Implement the directory callbacks and seek add seek tests Currently cannot seek on our stream wrapper Implement the directory callbacks * Implement rename * Fix CS for naming conventions * Fix tests for rewinding a directory * Handle the stream_open option flags. Add documentation about the allowed open modes. * Wrap download stream in a CachingStream if it must be seekable (getimagesize requires this) * Fix reference to debugging stream * Fix code style for isSeekable * Implement url_stat * Split buffering from the StreamableUploader into a WriteStream class (#2) * Split buffering from the StreamableUploader into a WriteStream class Implement ReadStream to wrap lazy downloaded stream to provide the size of the stream fix syntax error clean up stat array building Cleanup file mode constants Adding comments * Add ReadStream/WriteStream tests * Fixing stat tests * Add system tests for stream wrapper operations * Fix image test * Cannot use an array for constants * Fix unit tests to reflect mocks for refactored streams * Fixing system tests for url_stat for a directory without any files * Fix codestyle indentation issues. * Force our ReadStream to return the number of bytes requested. StreamInterface does not require this, however, the C internals do no expect that the stream returns less than the expected amount when filling its internal read buffer. This occurs specifically in getimagesize for jpeg images, when we try and read large amounts of exif data. * Documentation updates. Group private functions together. * Add custom phpcs ruleset. Ignore the camel case method name rule for StreamWrapper as the required callback method names are snake cased. * Updating docs for comments * ReadStream documentation updates * Handle Service exceptions when listing directories * rmdir now will attempt to delete the bucket if the path is '/' * Fix redefinition of method * Put the rename function back which was accidentally stomped * StreamWrapper can create the bucket and respect the specified mode. The mode int is extrapolated into one of publicRead, projectPrivate, or private. We will create a bucket if no path is given (i.e. gs://bucket-name-only/') or if the STREAM_MKDIR_RECURSIVE flag is provided. * Handle service exceptions when renaming files/directories * Can specify the chunkSize of the streaming upload via stream context. * Bucket->isWritable will now expect a 403 access denied. Any other ServiceException will be re-thrown. Also added some unit tests to account for this behavior.
jdpedrie
added a commit
that referenced
this issue
Mar 10, 2017
* Reorganize namespaces and fix tests * # This is a combination of 9 commits. # This is the 1st commit message: Reorganize namespaces and fix tests Update component versions via the CLI # This is the commit message #2: Create tags in components # This is the commit message #3: Send component name and version in user agent # This is the commit message #4: Add README files # This is the commit message #5: Fix CLI # This is the commit message #6: Add split to travis # This is the commit message #7: Test datastore release # This is the commit message #8: Compile splitsh # This is the commit message #9: Reintroduce full split process * # This is a combination of 2 commits. # This is the 1st commit message: Reorganize namespaces and fix tests Update component versions via the CLI Create tags in components Send component name and version in user agent Add README files Fix CLI Add split to travis Test datastore release Compile splitsh Reintroduce full split process Release patches # This is the commit message #2: Run split in each build matrix * Reorganize namespaces and fix tests Update component versions via the CLI Create tags in components Send component name and version in user agent Add README files Fix CLI Add split to travis Test datastore release Compile splitsh Reintroduce full split process Release patches Run split in each build matrix Release datastore patch enable set -e * Work with github API directly * Fix Vision class reference * Create VERSION file for all components * Remove componentName * Fix int64 snippet tests * Update component release target * Parse documentation separately for each component * This works now * Add flag to docs to use JSON_PRETTY_PRINT for debugging * Parse correct links between components * Fix unit tests * Doc links within component should not change version * Cross-component links should go to the correct version docs * Update snippets to remove refs to ServiceBuilder * Remove unnecessary env vars * Don't write VERSION for parent * Release packages * release v0.24.1 * Add autoloaders to each component * Pass libVersion to gax config * Update push docs command * add gcsUri helper * allow gcsUri or storage object * Release 0.24.2 * Update things again * this is the worst * Link to upstream tag * tag * Update table of contents * Reset versions * Update suggests and requires * fix build docs trigger * dont throw exceptions on decode * Fix docs link * Fix various doc issues * fix namespace
yoshi-automation
added
triage me
I really want to be triaged.
🚨
This issue needs some love.
labels
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/google/google-auth-library-php
The text was updated successfully, but these errors were encountered: