Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Exception in parser direct patch #1119

Closed
DiogoRMax opened this issue Jun 22, 2018 · 1 comment
Closed

[Firestore] Exception in parser direct patch #1119

DiogoRMax opened this issue Jun 22, 2018 · 1 comment
Assignees
@jdpedrie
Labels
api: firestore Issues related to the Firestore API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@DiogoRMax
Copy link
Contributor

DiogoRMax commented Jun 22, 2018 •
edited
Loading 

$firestore->collection('Kind')->document('F=76#509880146'); is ok!!
$firestore->document($firestore->collection('Kind')->name().'/F=76#509880146'); is ok!!
$firestore->document('Kind/F=76#509880146'); Exception in parser

This error with a direct patch only occurs with documents with keys with special characters, like '='...
@jdpedrie jdpedrie mentioned this issue Jun 22, 2018
Merged
@jdpedrie
Copy link
Contributor

Hi @DiogoRMax,

Thanks for the report. I've opened #1122 to address this issue.

@jdpedrie jdpedrie added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. api: firestore Issues related to the Firestore API. labels Jun 22, 2018
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Jun 22, 2018
@jdpedrie jdpedrie self-assigned this Jun 22, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Jun 22, 2018
@jdpedrie jdpedrie mentioned this issue Jun 25, 2018
Closed
jdpedrie added a commit that referenced this issue Jun 27, 2018
@jdpedrie
Support special characters in Firestore document paths (#1122)
7167794 
Fixes #1119.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdpedrie jdpedrie

Labels
api: firestore Issues related to the Firestore API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdpedrie @JustinBeckwith @DiogoRMax