chore: address PR comments

googleapis · Jan 3, 2024 · f190489 · f190489
1 parent 039c115
commit f190489
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/BigQuery/tests/Unit/Connection/RestTest.php b/BigQuery/tests/Unit/Connection/RestTest.php
@@ -71,7 +71,7 @@ public function clientUniverseDomainConfigProvider()
             [['apiEndpoint' => 'https://foobar.com'], 'https://foobar.com/bigquery/v2/'],
             [['universeDomain' => 'googleapis.com'], 'https://bigquery.googleapis.com/bigquery/v2/'],
             [['universeDomain' => 'abc.def.ghi'], 'https://bigquery.abc.def.ghi/bigquery/v2/'],
-            [['universeDomain' => ''], '', true],
+            [['universeDomain' => null], '', true],
         ];
     }
 

diff --git a/Core/src/RestTrait.php b/Core/src/RestTrait.php
@@ -145,7 +145,7 @@ private function getApiEndpoint($default, array $config, string $apiEndpointTemp
             );
         }
 
-        if (!isset($config['universeDomain']) || empty($config['universeDomain'])) {
+        if (!isset($config['universeDomain'])) {
             throw new UnexpectedValueException(
                 'The "universeDomain" config value must be set to use the default API endpoint template.'
             );

diff --git a/Core/tests/Unit/RestTraitTest.php b/Core/tests/Unit/RestTraitTest.php
@@ -218,8 +218,8 @@ public function universeDomains()
             [[], '', null, true],
             [[], null, null, true],
             [['universeDomain' => null], 'ab.cd', null, true],
-            [['universeDomain' => ''], 'ab.cd', null, true],
-            [['universeDomain' => 'defg'], 'ab.cd', 'ab.cd/'],
+            [['universeDomain' => ''], 'ab.cd/', 'ab.cd/'],
+            [['universeDomain' => 'defg'], '//ab.cd//', '//ab.cd//'],
             [['universeDomain' => 'defg'], 'ab.UNIVERSE_DOMAIN.cd', 'ab.defg.cd/'],
         ];
     }

diff --git a/PubSub/tests/Unit/Connection/RestTest.php b/PubSub/tests/Unit/Connection/RestTest.php
@@ -72,7 +72,7 @@ public function clientUniverseDomainConfigProvider()
             [['apiEndpoint' => 'https://foobar.com'], 'https://foobar.com/'],
             [['universeDomain' => 'googleapis.com'], 'https://pubsub.googleapis.com/'],
             [['universeDomain' => 'abc.def.ghi'], 'https://pubsub.abc.def.ghi/'],
-            [['universeDomain' => ''], '', true],
+            [['universeDomain' => null], '', true],
         ];
     }
 

diff --git a/Storage/tests/Unit/Connection/RestTest.php b/Storage/tests/Unit/Connection/RestTest.php
@@ -86,7 +86,7 @@ public function clientUniverseDomainConfigProvider()
             [['apiEndpoint' => 'https://foobar.com'], 'https://foobar.com/storage/v1/'],
             [['universeDomain' => 'googleapis.com'], 'https://storage.googleapis.com/storage/v1/'],
             [['universeDomain' => 'abc.def.ghi'], 'https://storage.abc.def.ghi/storage/v1/'],
-            [['universeDomain' => ''], '', true],
+            [['universeDomain' => null], '', true],
         ];
     }