Skip creating the labels info until there are labels. (#542)

Revert extension name change in test
googleapis · Jun 16, 2017 · f0856c7 · f0856c7
1 parent d75e733
commit f0856c7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Trace/TraceSpan.php b/src/Trace/TraceSpan.php
@@ -67,7 +67,7 @@ class TraceSpan implements \JsonSerializable
     public function __construct($options = [])
     {
         $this->info = $this->pluckArray(
-            ['spanId', 'kind', 'name', 'parentSpanId', 'labels'],
+            ['spanId', 'kind', 'name', 'parentSpanId'],
             $options
         );
 
@@ -78,6 +78,10 @@ public function __construct($options = [])
             $this->setEnd($options['endTime']);
         }
 
+        if (array_key_exists('labels', $options)) {
+            $this->addLabels($options['labels']);
+        }
+
         $this->info += [
             'kind' => self::SPAN_KIND_UNSPECIFIED
         ];

diff --git a/tests/unit/Trace/TraceSpanTest.php b/tests/unit/Trace/TraceSpanTest.php
@@ -67,6 +67,13 @@ public function testNoLabels()
         $this->assertArrayNotHasKey('labels', $info);
     }
 
+    public function testEmptyLabels()
+    {
+        $traceSpan = new TraceSpan(['labels' => []]);
+        $info = $traceSpan->info();
+        $this->assertArrayNotHasKey('labels', $info);
+    }
+
     public function testGeneratesDefaultSpanName()
     {
         $traceSpan = new TraceSpan();