adds service and version to exception handling (#689)

* adds service and version to exception handling * fixes BootstrapTest
googleapis · Sep 28, 2017 · d0d736e · d0d736e
1 parent 359f2d5
commit d0d736e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/ErrorReporting/Bootstrap.php b/src/ErrorReporting/Bootstrap.php
@@ -117,7 +117,14 @@ public static function exceptionHandler($ex)
     {
         $message = sprintf('PHP Notice: %s', (string)$ex);
         if (self::$psrLogger) {
-            self::$psrLogger->error($message);
+            $service = self::$psrLogger->getMetadataProvider()->serviceId();
+            $version = self::$psrLogger->getMetadataProvider()->versionId();
+            self::$psrLogger->error($message, [
+                'serviceContext' => [
+                    'service' => $service,
+                    'version' => $version,
+                ]
+            ]);
         } else {
             fwrite(STDERR, $message . PHP_EOL);
         }

diff --git a/tests/unit/ErrorReporting/BootstrapTest.php b/tests/unit/ErrorReporting/BootstrapTest.php
@@ -104,8 +104,17 @@ public function testExceptionHandler(
         $exception
     ) {
         $expectedMessage = sprintf('PHP Notice: %s', (string)$exception);
-        $this->psrBatchLogger->error($expectedMessage)
+        $expectedContext = [
+            'serviceContext' => [
+                'service' => '',
+                'version' => ''
+            ]
+        ];
+        $this->psrBatchLogger->error($expectedMessage, $expectedContext)
             ->shouldBeCalledTimes(1);
+        $this->psrBatchLogger->getMetadataProvider()
+            ->willReturn(new SimpleMetadataProvider())
+            ->shouldBeCalledTimes(2);
         Bootstrap::$psrLogger = $this->psrBatchLogger->reveal();
         Bootstrap::exceptionHandler($exception);
     }